* [PATCH] drivers: uio: Fix UIO device registration failure
@ 2013-03-26 1:31 Damian Hobson-Garcia
2013-03-26 1:47 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Damian Hobson-Garcia @ 2013-03-26 1:31 UTC (permalink / raw)
To: hjk, gregkh; +Cc: linux-kernel, Damian Hobson-Garcia
Until recently uio_get_minor() returned 0 for success and
a negative value on failure. This became non-negative for suceess and
negative for failure. Restore the original return value spec so that we can
successfully initialize UIO devices with a non-zero minor device
number.
Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
---
drivers/uio/uio.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index c8b9262..b645c47 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -374,6 +374,7 @@ static int uio_get_minor(struct uio_device *idev)
retval = idr_alloc(&uio_idr, idev, 0, UIO_MAX_DEVICES, GFP_KERNEL);
if (retval >= 0) {
idev->minor = retval;
+ retval = 0;
} else if (retval == -ENOSPC) {
dev_err(idev->dev, "too many uio devices\n");
retval = -EINVAL;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drivers: uio: Fix UIO device registration failure
2013-03-26 1:31 [PATCH] drivers: uio: Fix UIO device registration failure Damian Hobson-Garcia
@ 2013-03-26 1:47 ` Greg KH
2013-04-23 4:43 ` Sachin Kamat
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2013-03-26 1:47 UTC (permalink / raw)
To: hjk, linux-kernel; +Cc: Damian Hobson-Garcia
On Tue, Mar 26, 2013 at 10:31:22AM +0900, Damian Hobson-Garcia wrote:
> Until recently uio_get_minor() returned 0 for success and
> a negative value on failure. This became non-negative for suceess and
> negative for failure. Restore the original return value spec so that we can
> successfully initialize UIO devices with a non-zero minor device
> number.
>
> Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
> ---
> drivers/uio/uio.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Hans, don't you have a bunch of uio patches queued up for me? I've been
ignoring them, thinking you are collecting them, is this not true?
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: uio: Fix UIO device registration failure
2013-03-26 1:47 ` Greg KH
@ 2013-04-23 4:43 ` Sachin Kamat
0 siblings, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-04-23 4:43 UTC (permalink / raw)
To: Greg KH; +Cc: hjk, linux-kernel, Damian Hobson-Garcia
On 26 March 2013 07:17, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Mar 26, 2013 at 10:31:22AM +0900, Damian Hobson-Garcia wrote:
>> Until recently uio_get_minor() returned 0 for success and
>> a negative value on failure. This became non-negative for suceess and
>> negative for failure. Restore the original return value spec so that we can
>> successfully initialize UIO devices with a non-zero minor device
>> number.
>>
>> Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
>> ---
>> drivers/uio/uio.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> Hans, don't you have a bunch of uio patches queued up for me? I've been
> ignoring them, thinking you are collecting them, is this not true?
Greg, there isn't any response from Hans regarding the UIO patches.
Would you be picking them instead?
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-23 4:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26 1:31 [PATCH] drivers: uio: Fix UIO device registration failure Damian Hobson-Garcia
2013-03-26 1:47 ` Greg KH
2013-04-23 4:43 ` Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox