* [PATCH] rcu: don't allocate bootmem from rcu_init
@ 2013-03-26 15:35 Sasha Levin
2013-03-26 16:24 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2013-03-26 15:35 UTC (permalink / raw)
To: dipankar, paulmck; +Cc: linux-kernel, Sasha Levin
When rcu_init is called we already have slab working, allocating bootmem
at that point results in warnings and an allocation from slab.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
kernel/rcutree_plugin.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
index d084ae3..73bac82 100644
--- a/kernel/rcutree_plugin.h
+++ b/kernel/rcutree_plugin.h
@@ -87,7 +87,7 @@ static void __init rcu_bootup_announce_oddness(void)
#ifdef CONFIG_RCU_NOCB_CPU
#ifndef CONFIG_RCU_NOCB_CPU_NONE
if (!have_rcu_nocb_mask) {
- alloc_bootmem_cpumask_var(&rcu_nocb_mask);
+ alloc_cpumask_var(&rcu_nocb_mask, GFP_KERNEL);
have_rcu_nocb_mask = true;
}
#ifdef CONFIG_RCU_NOCB_CPU_ZERO
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rcu: don't allocate bootmem from rcu_init
2013-03-26 15:35 [PATCH] rcu: don't allocate bootmem from rcu_init Sasha Levin
@ 2013-03-26 16:24 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2013-03-26 16:24 UTC (permalink / raw)
To: Sasha Levin; +Cc: dipankar, linux-kernel
On Tue, Mar 26, 2013 at 11:35:16AM -0400, Sasha Levin wrote:
> When rcu_init is called we already have slab working, allocating bootmem
> at that point results in warnings and an allocation from slab.
Good catch, queued for 3.11, thank you!
Thanx, Paul
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
> kernel/rcutree_plugin.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
> index d084ae3..73bac82 100644
> --- a/kernel/rcutree_plugin.h
> +++ b/kernel/rcutree_plugin.h
> @@ -87,7 +87,7 @@ static void __init rcu_bootup_announce_oddness(void)
> #ifdef CONFIG_RCU_NOCB_CPU
> #ifndef CONFIG_RCU_NOCB_CPU_NONE
> if (!have_rcu_nocb_mask) {
> - alloc_bootmem_cpumask_var(&rcu_nocb_mask);
> + alloc_cpumask_var(&rcu_nocb_mask, GFP_KERNEL);
> have_rcu_nocb_mask = true;
> }
> #ifdef CONFIG_RCU_NOCB_CPU_ZERO
> --
> 1.8.1.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-26 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26 15:35 [PATCH] rcu: don't allocate bootmem from rcu_init Sasha Levin
2013-03-26 16:24 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox