From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Danny Baumann <dannybaumann@web.de>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] drm/i915: Allow specifying a minimum brightness level for sysfs control.
Date: Tue, 26 Mar 2013 17:02:03 +0000 [thread overview]
Message-ID: <20130326170203.GA23549@srcf.ucam.org> (raw)
In-Reply-To: <1364298525-4337-1-git-send-email-dannybaumann@web.de>
On Tue, Mar 26, 2013 at 12:48:44PM +0100, Danny Baumann wrote:
> This patch makes the behaviour of the intel_backlight backlight device
> consistent to e.g. acpi_videoX: When writing the value 0, the set brightness
> makes the panel content barely readable instead of turning the backlight off.
> This matches the expectations of user space (e.g. kde-workspace or the Intel
> X11 driver), which expects that it can use intel_backlight as a drop-in
> replacement for acpi_videoX.
I'm not quite clear what you mean here. The behaviour of "0" isn't well
defined for the ACPI backlight driver - it's perfectly reasonable for it
to turn the backlight off entirely. Anything assuming that "0" is still
visible is broken.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-03-26 17:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 11:48 [PATCH 0/1] drm/i915: Allow specifying a minimum brightness level for sysfs control Danny Baumann
2013-03-26 11:48 ` [PATCH 1/1] " Danny Baumann
2013-03-26 15:13 ` Daniel Vetter
2013-03-26 15:20 ` Chris Wilson
2013-03-26 17:04 ` Danny Baumann
2013-03-26 16:55 ` Danny Baumann
2013-03-26 17:02 ` Matthew Garrett [this message]
2013-03-26 17:10 ` [PATCH 0/1] " Danny Baumann
2013-03-26 17:21 ` Matthew Garrett
2013-03-27 11:56 ` Danny Baumann
2013-03-27 12:35 ` Alex Deucher
2013-03-27 12:56 ` Danny Baumann
2013-03-27 13:06 ` Alex Deucher
2013-03-27 15:10 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326170203.GA23549@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=airlied@linux.ie \
--cc=dannybaumann@web.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox