From: Arnd Bergmann <arnd@arndb.de>
To: Florian Fainelli <florian@openwrt.org>
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Subject: Re: [RFC PATCH 2/5] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol
Date: Tue, 26 Mar 2013 18:10:43 +0000 [thread overview]
Message-ID: <201303261810.44154.arnd@arndb.de> (raw)
In-Reply-To: <1364321177-12146-3-git-send-email-florian@openwrt.org>
On Tuesday 26 March 2013, Florian Fainelli wrote:
>
> Just like the OHCI counter part we just can remove the architecture
> specific symbols which prevent these configuration symbols from being
> selected by platforms/architectures requiring it. The original
> implementation did not scale at all since it required each and every
> single architecture to be added for these configuration symbols to be
> selected. Now it is up to the EHCI driver and/or platform to select
> these configuration symbols accordingly.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
Good idea, just one suggestion:
> config USB_EHCI_BIG_ENDIAN_MMIO
> bool
> - depends on USB_EHCI_HCD && (PPC_CELLEB || PPC_PS3 || 440EPX || \
> - ARCH_IXP4XX || XPS_USB_HCD_XILINX || \
> - PPC_MPC512x || CPU_CAVIUM_OCTEON || \
> - PMC_MSP || SPARC_LEON || MIPS_SEAD3)
> - default y
> + depends on USB_EHCI_HCD
> + default n
>
> config USB_EHCI_BIG_ENDIAN_DESC
> bool
> - depends on USB_EHCI_HCD && (440EPX || ARCH_IXP4XX || XPS_USB_HCD_XILINX || \
> - PPC_MPC512x || PMC_MSP || SPARC_LEON || \
> - MIPS_SEAD3)
> - default y
> + depends on USB_EHCI_HCD
> + default n
>
> config XPS_USB_HCD_XILINX
> bool "Use Xilinx usb host EHCI controller core"
You can drop the "default n" line as well, it's the default.
Arnd
next prev parent reply other threads:[~2013-03-26 18:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 18:06 [RFC PATCH 0/5] USB: Kconfig cleanups Florian Fainelli
2013-03-26 18:06 ` [RFC PATCH 1/5] USB: drop depends on USB and enclose everything into an if USB block Florian Fainelli
2013-03-26 19:04 ` Alan Stern
2013-03-26 19:56 ` Florian Fainelli
2013-03-26 18:06 ` [RFC PATCH 2/5] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol Florian Fainelli
2013-03-26 18:10 ` Arnd Bergmann [this message]
2013-03-26 19:08 ` Alan Stern
2013-03-29 21:31 ` Anatolij Gustschin
2013-03-26 18:06 ` [RFC PATCH 3/5] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block Florian Fainelli
2013-03-26 18:06 ` [RFC PATCH 4/5] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block Florian Fainelli
2013-03-26 18:06 ` [RFC PATCH 5/5] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block Florian Fainelli
2013-04-02 17:05 ` [PATCH 0/5] USB: Kconfig cleanups Florian Fainelli
2013-04-02 17:05 ` [PATCH 1/5] USB: regroup all depends on USB within an if USB block Florian Fainelli
2013-04-02 17:05 ` [PATCH 2/5] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol Florian Fainelli
2013-04-02 17:05 ` [PATCH 3/5] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block Florian Fainelli
2013-04-02 17:05 ` [PATCH 4/5] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block Florian Fainelli
2013-04-02 17:05 ` [PATCH 5/5] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block Florian Fainelli
2013-04-02 17:10 ` [PATCH 0/5] USB: Kconfig cleanups Florian Fainelli
2013-04-02 17:10 ` [PATCH 0/5 v2] " Florian Fainelli
2013-04-02 17:10 ` [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block Florian Fainelli
2013-04-02 18:06 ` Alan Stern
2013-04-03 12:11 ` Florian Fainelli
2013-04-03 12:15 ` Felipe Balbi
2013-04-03 12:18 ` Florian Fainelli
2013-04-03 12:21 ` Felipe Balbi
2013-04-03 18:10 ` Alan Stern
2013-04-02 18:19 ` balbi
2013-04-03 11:54 ` Florian Fainelli
2013-04-02 17:10 ` [PATCH 2/5 v2] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol Florian Fainelli
2013-04-02 18:21 ` Alan Stern
2013-04-02 17:10 ` [PATCH 3/5 v2] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block Florian Fainelli
2013-04-02 18:33 ` Alan Stern
2013-04-02 17:10 ` [PATCH 4/5 v2] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block Florian Fainelli
2013-04-02 18:42 ` Alan Stern
2013-04-02 17:10 ` [PATCH 5/5 v2] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block Florian Fainelli
2013-04-02 18:43 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303261810.44154.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=florian@openwrt.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox