From: Greg KH <gregkh@linuxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [char-misc-next 2/2] mei: drop RECOVERING_FROM_RESET device state
Date: Tue, 26 Mar 2013 16:00:50 -0700 [thread overview]
Message-ID: <20130326230050.GA25071@kroah.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B01EF3427@HASMSX106.ger.corp.intel.com>
On Tue, Mar 26, 2013 at 10:47:31PM +0000, Winkler, Tomas wrote:
> >
> > On Sun, Mar 17, 2013 at 11:41:21AM +0200, Tomas Winkler wrote:
> > > ECOVERING_FROM_RESET device state is never set we can remove it
> >
> > Really? I now get the following build error with this patch applied:
> >
> > drivers/misc/mei/pci-me.c: In function ‘mei_pci_suspend’:
> > drivers/misc/mei/pci-me.c:323:24: error:
> > ‘MEI_DEV_RECOVERING_FROM_RESET’ undeclared (first use in this
> > function)
> > drivers/misc/mei/pci-me.c:323:24: note: each undeclared identifier is
> > reported only once for each function it appears in
> >
> > Please be more careful.
>
> This patch has to be applied above patch https://lkml.org/lkml/2013/3/10/101 that is queued for 3.9.
> Somehow I've assumed it will go into 3.9-rc4.
Yes, I hope to get it there.
> Anyhow we need to wait with this and everything else I have queued till it is merged back to char-misc-next.
> Maybe you have some suggestions how to handle such conflicts in the future.
Let me know about such conflicts so I don't blame you for them :)
I'll pull in the char-misc.linus branch into my .next branch now, so
that should solve this problem, right? If so, please resend this patch
so I can apply it.
thanks,
greg k-h
prev parent reply other threads:[~2013-03-26 23:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 9:41 [char-misc-next 1/2] mei: add mei_irq_compl_handler function Tomas Winkler
2013-03-17 9:41 ` [char-misc-next 2/2] mei: drop RECOVERING_FROM_RESET device state Tomas Winkler
2013-03-25 20:21 ` Greg KH
2013-03-26 22:47 ` Winkler, Tomas
2013-03-26 23:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326230050.GA25071@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox