From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Andrei Epure <epure.andrei@gmail.com>
Cc: cbou@mail.ru, dwmw2@infradead.org, milo.kim@ti.com,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] power: pass IRQF_ONESHOT to request_threaded_irq()
Date: Thu, 28 Mar 2013 01:06:12 +0000 [thread overview]
Message-ID: <20130328010611.GV18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1364431370-25029-1-git-send-email-epure.andrei@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 558 bytes --]
On Thu, Mar 28, 2013 at 02:42:50AM +0200, Andrei Epure wrote:
> Patch found using coccinelle.
>
> Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
Some of these may be false positives especially for PMICs - often the
interrupts are guaranteed to be generated from the interrupt controller
on the device which runs in thread context.
More generally though why not fix this in request_threaded_irq() itself,
if there's no hard IRQ handler then add the flag transparently? It'd
save boilerplate. Indeed I could've sworn someone did that...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-03-28 1:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 0:42 [PATCH] power: pass IRQF_ONESHOT to request_threaded_irq() Andrei Epure
2013-03-28 1:06 ` Mark Brown [this message]
2013-03-28 1:19 ` Kim, Milo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328010611.GV18316@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=epure.andrei@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox