* [PATCH -next] mg_disk: fix error return code in mg_probe()
@ 2013-03-28 4:31 Wei Yongjun
2013-03-28 4:43 ` Jingoo Han
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-03-28 4:31 UTC (permalink / raw)
To: jg1.han, akpm, rjw; +Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/block/mg_disk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c
index 532bb89..a56cfcd 100644
--- a/drivers/block/mg_disk.c
+++ b/drivers/block/mg_disk.c
@@ -892,8 +892,10 @@ static int mg_probe(struct platform_device *plat_dev)
gpio_direction_output(host->rst, 1);
/* reset out pin */
- if (!(prv_data->dev_attr & MG_DEV_MASK))
+ if (!(prv_data->dev_attr & MG_DEV_MASK)) {
+ err = -EINVAL;
goto probe_err_3a;
+ }
if (prv_data->dev_attr != MG_BOOT_DEV) {
rsc = platform_get_resource_byname(plat_dev, IORESOURCE_IO,
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] mg_disk: fix error return code in mg_probe()
2013-03-28 4:31 [PATCH -next] mg_disk: fix error return code in mg_probe() Wei Yongjun
@ 2013-03-28 4:43 ` Jingoo Han
2013-03-28 15:44 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2013-03-28 4:43 UTC (permalink / raw)
To: 'Wei Yongjun', 'Andrew Morton'
Cc: 'Rafael J. Wysocki', 'Jens Axboe', yongjun_wei,
linux-kernel, 'Jingoo Han'
On Thursday, March 28, 2013 1:32 PM, Wei Yongjun wrote:
>
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
CC'ed Jens Axboe
It looks good.
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/block/mg_disk.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c
> index 532bb89..a56cfcd 100644
> --- a/drivers/block/mg_disk.c
> +++ b/drivers/block/mg_disk.c
> @@ -892,8 +892,10 @@ static int mg_probe(struct platform_device *plat_dev)
> gpio_direction_output(host->rst, 1);
>
> /* reset out pin */
> - if (!(prv_data->dev_attr & MG_DEV_MASK))
> + if (!(prv_data->dev_attr & MG_DEV_MASK)) {
> + err = -EINVAL;
> goto probe_err_3a;
> + }
>
> if (prv_data->dev_attr != MG_BOOT_DEV) {
> rsc = platform_get_resource_byname(plat_dev, IORESOURCE_IO,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] mg_disk: fix error return code in mg_probe()
2013-03-28 4:43 ` Jingoo Han
@ 2013-03-28 15:44 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2013-03-28 15:44 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Wei Yongjun', 'Andrew Morton',
'Rafael J. Wysocki', yongjun_wei, linux-kernel
On Thu, Mar 28 2013, Jingoo Han wrote:
> On Thursday, March 28, 2013 1:32 PM, Wei Yongjun wrote:
> >
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > Fix to return a negative error code from the error handling
> > case instead of 0, as returned elsewhere in this function.
> >
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> CC'ed Jens Axboe
>
> It looks good.
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Applied, thanks guys.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-28 15:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-28 4:31 [PATCH -next] mg_disk: fix error return code in mg_probe() Wei Yongjun
2013-03-28 4:43 ` Jingoo Han
2013-03-28 15:44 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox