From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: David Howells <dhowells@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h
Date: Thu, 28 Mar 2013 17:10:48 -0700 [thread overview]
Message-ID: <20130329001048.GK5995@xanatos> (raw)
In-Reply-To: <32349.1364509973@warthog.procyon.org.uk>
On Thu, Mar 28, 2013 at 10:32:53PM +0000, David Howells wrote:
> Sarah Sharp <sarah.a.sharp@linux.intel.com> wrote:
>
> > I'm a little bit confused about your description for the second one.
> > Did you need to change the #defines names because they could conflict
> > with other drivers when the xHCI driver is built in? Or is there some
> > other point I'm missing?
>
> Sorry, I should say. I'm trying to clean up the UAPI headers and I noticed
> that the xHCI SEGMENT_SIZE macro is named the same as one defined by a.out.h
> that cannot be changed as it is seen by userspace. Although it's unlikely
> that within the kernel they are unlikely to collide, one cannot be entirely
> sure that will stay true as new arches get added (hopefully no one will add
> new arches that use a.out format). It seems best that the xHCI one be renamed
> if possible.
I guess my question is a deeper one: do we need to rename all the xHCI
macros to have the XHCI_ prefix, in order to avoid future collision?
For example, one of the macros is MAX_HC_PORTS, which could possibly be
used by other host drivers in the future.
Note that I'm not asking you to do this, just if it needs to be done.
Sarah Sharp
next prev parent reply other threads:[~2013-03-29 0:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 18:48 [PATCH 1/2] xhci: Use ilog2() rather than __ffs() for calculating SEGMENT_SHIFT David Howells
2013-03-28 18:48 ` [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h David Howells
2013-03-28 20:15 ` Sarah Sharp
2013-03-28 22:32 ` David Howells
2013-03-29 0:10 ` Sarah Sharp [this message]
2013-04-02 18:07 ` David Howells
2013-04-02 19:37 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130329001048.GK5995@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox