From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>, Felipe Balbi <balbi@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [rtmutex-tester] WARNING: at drivers/base/core.c:569 device_create_file()
Date: Fri, 29 Mar 2013 09:34:24 -0700 [thread overview]
Message-ID: <20130329163424.GA3380@kroah.com> (raw)
In-Reply-To: <20130329021704.GA9457@localhost>
On Fri, Mar 29, 2013 at 10:17:04AM +0800, Fengguang Wu wrote:
> Hi Kay,
>
> I got the below warning and the first "bad" commit is
>
> commit 8f46baaa7ec6cd0851794020b31958e64679dd26
> Author: Felipe Balbi <balbi@ti.com>
> Date: Wed Feb 20 10:31:42 2013 +0200
>
> base: core: WARN() about bogus permissions on device attributes
>
> Whenever a struct device_attribute is registered
> with mismatched permissions - read permission without
> a show routine or write permission without store
> routine - we will issue a big warning so we catch
> those early enough.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
That's just a "warning" patch, I'll fix this up properly
(kernel/rtmutex-tester.c has 0600 as the mode for a read-only attribute
as well as a write-only attribute.)
thanks,
greg k-h
prev parent reply other threads:[~2013-03-29 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 2:17 [rtmutex-tester] WARNING: at drivers/base/core.c:569 device_create_file() Fengguang Wu
2013-03-29 16:34 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130329163424.GA3380@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@ti.com \
--cc=fengguang.wu@intel.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox