From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] regmap: cache: Factor out reg_present support from rbtree cache
Date: Sat, 30 Mar 2013 01:11:37 +0000 [thread overview]
Message-ID: <20130330011137.GA26560@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1364591025-18525-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Fri, Mar 29, 2013 at 09:03:42PM +0000, Mark Brown wrote:
> The idea of maintaining a bitmap of present registers is something that
> can usefully be used by other cache types that maintain blocks of cached
> registers so move the code out of the rbtree cache and into the generic
> regcache code.
>
> Refactor the interface slightly as we go to wrap the set bit and enlarge
> bitmap operations (since we never do one without the other) and make it
> more robust for reads of uncached registers by bounds checking before we
> look at the bitmap.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Looks good.
Reviewed-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
prev parent reply other threads:[~2013-03-30 1:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 21:03 [PATCH 1/4] regmap: cache: Factor out reg_present support from rbtree cache Mark Brown
2013-03-29 21:03 ` [PATCH 2/4] regmap: cache: Factor out block sync Mark Brown
2013-03-30 1:12 ` Dimitris Papastamos
2013-03-29 21:03 ` [PATCH 3/4] regmap: cache: Split raw and non-raw syncs Mark Brown
2013-03-30 1:13 ` Dimitris Papastamos
2013-03-29 21:03 ` [PATCH 4/4] regmap: cache: Write consecutive registers in a single block write Mark Brown
2013-03-30 1:13 ` Dimitris Papastamos
2013-03-30 1:11 ` Dimitris Papastamos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130330011137.GA26560@opensource.wolfsonmicro.com \
--to=dp@opensource.wolfsonmicro.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox