From: Greg KH <gregkh@linuxfoundation.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: jhovold@gmail.com, Jiri Slaby <jslaby@suse.cz>,
mferrell@uplogix.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Suggestion] drivers/usb/serial: looping issue: return value may override by looping
Date: Sun, 31 Mar 2013 20:05:55 -0700 [thread overview]
Message-ID: <20130401030555.GA21113@kroah.com> (raw)
In-Reply-To: <5158F689.5040406@asianux.com>
On Mon, Apr 01, 2013 at 10:52:57AM +0800, Chen Gang wrote:
> Hello Maintainers:
>
> in drivers/usb/serial/mos7840.c:
>
> in 'for' looping (line 632..657)
> the return value 'rv' may override if not have a check in time (line 654)
>
> next checking can not find failure which generated during looping (line 658)
>
> please help check, thanks.
No. Please send real patches if you think something is wrong, after
determining something is incorrect. To waste people's time like this,
checking to see if you have misunderstood something, does not scale at
all, please be more considerate.
greg k-h
next prev parent reply other threads:[~2013-04-01 3:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 2:52 [Suggestion] drivers/usb/serial: looping issue: return value may override by looping Chen Gang
2013-04-01 3:05 ` Greg KH [this message]
2013-04-01 3:21 ` Chen Gang
2013-04-01 3:50 ` [PATCH] drivers/usb/serial: looping issue: avoid the return value overriden " Chen Gang
2013-04-01 19:37 ` USB: mos7840: " Greg KH
2013-04-02 1:03 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401030555.GA21113@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gang.chen@asianux.com \
--cc=jhovold@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mferrell@uplogix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox