From: Shiraz Hashim <shiraz.hashim@st.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Axel Lin <axel.lin@ingics.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] pwm: spear: Fix enable pwm output
Date: Mon, 1 Apr 2013 09:19:25 +0530 [thread overview]
Message-ID: <20130401034925.GA21313@localhost.localdomain> (raw)
In-Reply-To: <CAKohpo=xQC_pzc19RP1TncO3XJLj7k-_JyvT3n9UZFTEjYOizw@mail.gmail.com>
On Sat, Mar 30, 2013 at 05:55:41PM +0800, Viresh Kumar wrote:
> On 30 March 2013 11:07, Axel Lin <axel.lin@ingics.com> wrote:
> > The logic to check return value of clk_enable() is reversed, thus
> > when clk_enable() passes PWMCR_PWM_ENABLE bit is not set. Fix it.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> > drivers/pwm/pwm-spear.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> I am so sorry. clk_prepare also has the same issue :(
> Please fix that too and i will ack it ASAP.
>
> @Shiraz: Any idea how they went through?
I don't remember how :(, surely a mistake which escaped tests also.
--
regards
Shiraz
prev parent reply other threads:[~2013-04-01 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 5:37 [PATCH v2] pwm: spear: Fix enable pwm output Axel Lin
2013-03-30 9:55 ` Viresh Kumar
2013-04-01 3:49 ` Shiraz Hashim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401034925.GA21313@localhost.localdomain \
--to=shiraz.hashim@st.com \
--cc=axel.lin@ingics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox