From: Shiraz Hashim <shiraz.hashim@st.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
Viresh Kumar <viresh.kumar@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip
Date: Mon, 1 Apr 2013 09:22:10 +0530 [thread overview]
Message-ID: <20130401035210.GB21313@localhost.localdomain> (raw)
In-Reply-To: <1364784565.7725.2.camel@phoenix>
Hi Axel,
Perhaps you meant pwm: spear: (instead of pwm: mxs) in the subject
line.
On Mon, Apr 01, 2013 at 10:49:25AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-spear.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
> index 3223b57..9563599 100644
> --- a/drivers/pwm/pwm-spear.c
> +++ b/drivers/pwm/pwm-spear.c
> @@ -49,13 +49,11 @@
> * @mmio_base: base address of pwm chip
> * @clk: pointer to clk structure of pwm chip
> * @chip: linux pwm chip representation
> - * @dev: pointer to device structure of pwm chip
> */
> struct spear_pwm_chip {
> void __iomem *mmio_base;
> struct clk *clk;
> struct pwm_chip chip;
> - struct device *dev;
> };
>
> static inline struct spear_pwm_chip *to_spear_pwm_chip(struct pwm_chip *chip)
> @@ -200,7 +198,6 @@ static int spear_pwm_probe(struct platform_device *pdev)
> if (IS_ERR(pc->clk))
> return PTR_ERR(pc->clk);
>
> - pc->dev = &pdev->dev;
> platform_set_drvdata(pdev, pc);
>
> pc->chip.dev = &pdev->dev;
> --
> 1.7.10.4
otherwise,
Acked-by: Shiraz Hashim <shiraz.hashim@st.com>
next prev parent reply other threads:[~2013-04-01 3:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 2:48 [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip Axel Lin
2013-04-01 2:49 ` [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip Axel Lin
2013-04-01 3:52 ` Shiraz Hashim [this message]
2013-04-01 4:48 ` Viresh Kumar
2013-04-01 6:56 ` [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip Shawn Guo
2013-04-02 9:40 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401035210.GB21313@localhost.localdomain \
--to=shiraz.hashim@st.com \
--cc=axel.lin@ingics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox