From: Anton Vorontsov <anton@enomsg.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
Evgeny Romanov <romanov@neurosoft.ru>
Subject: Re: [PATCH 1/5] power: ds2782_battery: Use dev_pm_ops
Date: Sun, 31 Mar 2013 23:00:52 -0700 [thread overview]
Message-ID: <20130401060052.GA30190@lizard> (raw)
In-Reply-To: <1362922449-27531-1-git-send-email-lars@metafoo.de>
On Sun, Mar 10, 2013 at 02:34:05PM +0100, Lars-Peter Clausen wrote:
> Use dev_pm_ops instead of the deprecated legacy suspend/resume callbacks.
>
> Cc: Evgeny Romanov <romanov@neurosoft.ru>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
[...]
> @@ -465,11 +466,10 @@ MODULE_DEVICE_TABLE(i2c, ds278x_id);
> static struct i2c_driver ds278x_battery_driver = {
> .driver = {
> .name = "ds2782-battery",
> + .pm = DS278X_BATERY_PM_OPS,
Typo: BATTERY.
CHECK drivers/power/ds2782_battery.c
drivers/power/ds2782_battery.c:464:27: error: undefined identifier 'DS278X_BATERY_PM_OPS'
CC drivers/power/ds2782_battery.o
drivers/power/ds2782_battery.c:464:9: error: ‘DS278X_BATERY_PM_OPS’ undeclared here (not in a function)
make[1]: *** [drivers/power/ds2782_battery.o] Error 1
I fixed it up and applied the patch...
Thanks,
Anton
> },
> .probe = ds278x_battery_probe,
> .remove = ds278x_battery_remove,
> - .suspend = ds278x_suspend,
> - .resume = ds278x_resume,
> .id_table = ds278x_id,
> };
> module_i2c_driver(ds278x_battery_driver);
prev parent reply other threads:[~2013-04-01 6:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 13:34 [PATCH 1/5] power: ds2782_battery: Use dev_pm_ops Lars-Peter Clausen
2013-03-10 13:34 ` [PATCH 2/5] power: max17040_battery: " Lars-Peter Clausen
2013-03-12 5:59 ` Minkyu Kang
2013-04-01 6:00 ` Anton Vorontsov
2013-03-10 13:34 ` [PATCH 3/5] power: sbs-battery: " Lars-Peter Clausen
2013-03-11 18:05 ` Rhyland Klein
2013-03-10 13:34 ` [PATCH 4/5] power: pm2301_charger: Remove __dev* annotations Lars-Peter Clausen
2013-03-25 3:09 ` Anton Vorontsov
2013-03-10 13:34 ` [PATCH 5/5] power: pm2301_charger: Remove no-op suspend/resume callbacks Lars-Peter Clausen
2013-04-01 6:00 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401060052.GA30190@lizard \
--to=anton@enomsg.org \
--cc=dwmw2@infradead.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=romanov@neurosoft.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).