public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 21/21] power: fix invalid free of devm_ allocated data
@ 2013-03-28  0:51 Andrei Epure
  2013-04-01  6:43 ` Anton Vorontsov
  0 siblings, 1 reply; 2+ messages in thread
From: Andrei Epure @ 2013-03-28  0:51 UTC (permalink / raw)
  To: cbou, dwmw2; +Cc: linux-kernel, Andrei Epure

The objects allocated by devm_* APIs are managed by devres and are freed when
the device is detached. Hence there is no need to use kfree() explicitly.
Patch found using coccinelle.

Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
---
 drivers/power/88pm860x_charger.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/power/88pm860x_charger.c b/drivers/power/88pm860x_charger.c
index 4b37a5a..36fb4b5 100644
--- a/drivers/power/88pm860x_charger.c
+++ b/drivers/power/88pm860x_charger.c
@@ -714,7 +714,6 @@ out_irq:
 	while (--i >= 0)
 		free_irq(info->irq[i], info);
 out:
-	kfree(info);
 	return ret;
 }
 
@@ -728,7 +727,6 @@ static int pm860x_charger_remove(struct platform_device *pdev)
 	free_irq(info->irq[0], info);
 	for (i = 0; i < info->irq_nums; i++)
 		free_irq(info->irq[i], info);
-	kfree(info);
 	return 0;
 }
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-04-01  6:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-28  0:51 [PATCH 21/21] power: fix invalid free of devm_ allocated data Andrei Epure
2013-04-01  6:43 ` Anton Vorontsov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox