RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address

Yang, Wenyou
2013-04-02T06:17:17Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1720 bytes --]

Hi, Mark,

> -----Original Message-----
> From: Yang, Wenyou
> Sent: 2013Äê4ÔÂ2ÈÕ 13:50
> To: 'Mark Brown'
> Cc: linux-arm-kernel@lists.infradead.org; grant.likely@secretlab.ca;
> richard.genoud@gmail.com; plagnioj@jcrosoft.com; Ferre, Nicolas; Lin, JM;
> spi-devel-general@lists.sourceforge.net; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address
>
> Hi, Mark,
>
> > -----Original Message-----
> > From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> > Sent: 2013Äê4ÔÂ1ÈÕ 21:42
> > To: Yang, Wenyou
> > Cc: linux-arm-kernel@lists.infradead.org; grant.likely@secretlab.ca;
> > richard.genoud@gmail.com; plagnioj@jcrosoft.com; Ferre, Nicolas; Lin, JM;
> > spi-devel-general@lists.sourceforge.net; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v7 03/14] spi/spi-atmel: add physical base address
> >
> > On Tue, Mar 19, 2013 at 03:43:36PM +0800, Wenyou Yang wrote:
> >
> > > +++ b/drivers/spi/spi-atmel.c
> > > @@ -196,6 +196,7 @@ struct atmel_spi_caps { struct atmel_spi {
> > > spinlock_t lock;
> > >
> > > + resource_size_t phybase;
> > > void __iomem *regs;
> > > int irq;
> > > struct clk *clk;
> >
> > This looks like the wrong type?
>
I got it, you are right, you mean It should be used " phys_addr_t " type.

phys_addr_t phybase;

Thanks.

Best Regards,
Wenyou Yang.

> I double checked.
>
> The type ' resource_size_t ' is defined in include/linux/ types.h as below,
>
> typedef phys_addr_t resource_size_t;
>
> I think it is OK.
>
> Best Regards,
> Wenyou Yang
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥