From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Kees Cook <keescook@chromium.org>, Jiri Slaby <jslaby@suse.cz>,
Sebastian Gottschall <s.gottschall@dd-wrt.com>,
LKML <linux-kernel@vger.kernel.org>,
"# 3.4.x" <stable@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Build breakage in 3.8.4 [was: Linux 3.8.4]
Date: Mon, 1 Apr 2013 16:47:26 -0700 [thread overview]
Message-ID: <20130401234726.GA25060@kroah.com> (raw)
In-Reply-To: <1364362994.3520.54.camel@deadeye.wl.decadent.org.uk>
On Wed, Mar 27, 2013 at 05:43:14AM +0000, Ben Hutchings wrote:
> On Tue, 2013-03-26 at 09:18 -0700, Greg KH wrote:
> > On Tue, Mar 26, 2013 at 08:56:20AM -0700, Kees Cook wrote:
> > > On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby <jslaby@suse.cz> wrote:
> > > > On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
> > > >
> > > >> Am 20.03.2013 21:15, schrieb Greg KH:
> > > >>> I'm announcing the release of the 3.8.4 kernel.
> > > > ...
> > > >>> signal: always clear sa_restorer on execve
> > > >> consider that this kernel is not compileable on mips targets due the
> > > >> patch in kernel/signal.c
> > > >>
> > > >> SA_RESTORER is defined in mips, but sa_restorer does not exist on that
> > > >> platform
> > > >
> > > > The same for ia64...
> > > >
> > > > kernel/signal.c: In function 'flush_signal_handlers':
> > > > kernel/signal.c:441: error: 'struct sigaction' has no member named
> > > > 'sa_restorer'
> > > >
> > > > Do we need this in 3.0, 3.4, 3.8 too?
> > > > commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
> > > > Author: Andrew Morton <akpm@linux-foundation.org>
> > > > Date: Wed Mar 13 14:59:34 2013 -0700
> > > >
> > > > kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
> > > >
> > > > __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and
> > > > later kernels, per Kees.
> > >
> > > Hrm, if so, we'll need to also backport the changes that aded
> > > __ARCH_HAS_SA_RESTORER...
> >
> > Ok, well, can someone provide me the needed patches? Otherwise I will
> > have to revert the offending change from the stable releases.
>
> For the third time... use the attached patch followed by Andrew's commit
> 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a.
Sorry for being thick, you are right, now applied, thanks.
greg k-h
next prev parent reply other threads:[~2013-04-01 23:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 20:15 Linux 3.8.4 Greg KH
2013-03-20 20:16 ` Greg KH
2013-03-20 22:25 ` Sebastian Gottschall
2013-03-24 19:31 ` Build breakage in 3.8.4 [was: Linux 3.8.4] Jiri Slaby
2013-03-26 15:56 ` Kees Cook
2013-03-26 16:18 ` Greg KH
2013-03-27 5:43 ` Ben Hutchings
2013-04-01 23:47 ` Greg KH [this message]
2013-03-26 16:35 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401234726.GA25060@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=jslaby@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.gottschall@dd-wrt.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox