* [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip
@ 2013-04-01 2:48 Axel Lin
2013-04-01 2:49 ` [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip Axel Lin
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Axel Lin @ 2013-04-01 2:48 UTC (permalink / raw)
To: Thierry Reding; +Cc: Shawn Guo, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pwm/pwm-mxs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
index a53d309..23d5180 100644
--- a/drivers/pwm/pwm-mxs.c
+++ b/drivers/pwm/pwm-mxs.c
@@ -38,7 +38,6 @@
struct mxs_pwm_chip {
struct pwm_chip chip;
- struct device *dev;
struct clk *clk;
void __iomem *base;
};
@@ -166,7 +165,6 @@ static int mxs_pwm_probe(struct platform_device *pdev)
return ret;
}
- mxs->dev = &pdev->dev;
platform_set_drvdata(pdev, mxs);
stmp_reset_block(mxs->base);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip
2013-04-01 2:48 [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip Axel Lin
@ 2013-04-01 2:49 ` Axel Lin
2013-04-01 3:52 ` Shiraz Hashim
2013-04-01 4:48 ` Viresh Kumar
2013-04-01 6:56 ` [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip Shawn Guo
2013-04-02 9:40 ` Thierry Reding
2 siblings, 2 replies; 6+ messages in thread
From: Axel Lin @ 2013-04-01 2:49 UTC (permalink / raw)
To: Thierry Reding; +Cc: Viresh Kumar, Shiraz Hashim, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pwm/pwm-spear.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
index 3223b57..9563599 100644
--- a/drivers/pwm/pwm-spear.c
+++ b/drivers/pwm/pwm-spear.c
@@ -49,13 +49,11 @@
* @mmio_base: base address of pwm chip
* @clk: pointer to clk structure of pwm chip
* @chip: linux pwm chip representation
- * @dev: pointer to device structure of pwm chip
*/
struct spear_pwm_chip {
void __iomem *mmio_base;
struct clk *clk;
struct pwm_chip chip;
- struct device *dev;
};
static inline struct spear_pwm_chip *to_spear_pwm_chip(struct pwm_chip *chip)
@@ -200,7 +198,6 @@ static int spear_pwm_probe(struct platform_device *pdev)
if (IS_ERR(pc->clk))
return PTR_ERR(pc->clk);
- pc->dev = &pdev->dev;
platform_set_drvdata(pdev, pc);
pc->chip.dev = &pdev->dev;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip
2013-04-01 2:49 ` [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip Axel Lin
@ 2013-04-01 3:52 ` Shiraz Hashim
2013-04-01 4:48 ` Viresh Kumar
1 sibling, 0 replies; 6+ messages in thread
From: Shiraz Hashim @ 2013-04-01 3:52 UTC (permalink / raw)
To: Axel Lin; +Cc: Thierry Reding, Viresh Kumar, linux-kernel@vger.kernel.org
Hi Axel,
Perhaps you meant pwm: spear: (instead of pwm: mxs) in the subject
line.
On Mon, Apr 01, 2013 at 10:49:25AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-spear.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
> index 3223b57..9563599 100644
> --- a/drivers/pwm/pwm-spear.c
> +++ b/drivers/pwm/pwm-spear.c
> @@ -49,13 +49,11 @@
> * @mmio_base: base address of pwm chip
> * @clk: pointer to clk structure of pwm chip
> * @chip: linux pwm chip representation
> - * @dev: pointer to device structure of pwm chip
> */
> struct spear_pwm_chip {
> void __iomem *mmio_base;
> struct clk *clk;
> struct pwm_chip chip;
> - struct device *dev;
> };
>
> static inline struct spear_pwm_chip *to_spear_pwm_chip(struct pwm_chip *chip)
> @@ -200,7 +198,6 @@ static int spear_pwm_probe(struct platform_device *pdev)
> if (IS_ERR(pc->clk))
> return PTR_ERR(pc->clk);
>
> - pc->dev = &pdev->dev;
> platform_set_drvdata(pdev, pc);
>
> pc->chip.dev = &pdev->dev;
> --
> 1.7.10.4
otherwise,
Acked-by: Shiraz Hashim <shiraz.hashim@st.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip
2013-04-01 2:49 ` [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip Axel Lin
2013-04-01 3:52 ` Shiraz Hashim
@ 2013-04-01 4:48 ` Viresh Kumar
1 sibling, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2013-04-01 4:48 UTC (permalink / raw)
To: Axel Lin; +Cc: Thierry Reding, Shiraz Hashim, linux-kernel
On 1 April 2013 08:19, Axel Lin <axel.lin@ingics.com> wrote:
Apart from fixing subject you need to write something in logs too..
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-spear.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
> index 3223b57..9563599 100644
> --- a/drivers/pwm/pwm-spear.c
> +++ b/drivers/pwm/pwm-spear.c
> @@ -49,13 +49,11 @@
> * @mmio_base: base address of pwm chip
> * @clk: pointer to clk structure of pwm chip
> * @chip: linux pwm chip representation
> - * @dev: pointer to device structure of pwm chip
> */
> struct spear_pwm_chip {
> void __iomem *mmio_base;
> struct clk *clk;
> struct pwm_chip chip;
> - struct device *dev;
> };
>
> static inline struct spear_pwm_chip *to_spear_pwm_chip(struct pwm_chip *chip)
> @@ -200,7 +198,6 @@ static int spear_pwm_probe(struct platform_device *pdev)
> if (IS_ERR(pc->clk))
> return PTR_ERR(pc->clk);
>
> - pc->dev = &pdev->dev;
> platform_set_drvdata(pdev, pc);
>
> pc->chip.dev = &pdev->dev;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip
2013-04-01 2:48 [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip Axel Lin
2013-04-01 2:49 ` [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip Axel Lin
@ 2013-04-01 6:56 ` Shawn Guo
2013-04-02 9:40 ` Thierry Reding
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2013-04-01 6:56 UTC (permalink / raw)
To: Axel Lin; +Cc: Thierry Reding, linux-kernel
On Mon, Apr 01, 2013 at 10:48:13AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/pwm/pwm-mxs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
> index a53d309..23d5180 100644
> --- a/drivers/pwm/pwm-mxs.c
> +++ b/drivers/pwm/pwm-mxs.c
> @@ -38,7 +38,6 @@
>
> struct mxs_pwm_chip {
> struct pwm_chip chip;
> - struct device *dev;
> struct clk *clk;
> void __iomem *base;
> };
> @@ -166,7 +165,6 @@ static int mxs_pwm_probe(struct platform_device *pdev)
> return ret;
> }
>
> - mxs->dev = &pdev->dev;
> platform_set_drvdata(pdev, mxs);
>
> stmp_reset_block(mxs->base);
> --
> 1.7.10.4
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip
2013-04-01 2:48 [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip Axel Lin
2013-04-01 2:49 ` [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip Axel Lin
2013-04-01 6:56 ` [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip Shawn Guo
@ 2013-04-02 9:40 ` Thierry Reding
2 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2013-04-02 9:40 UTC (permalink / raw)
To: Axel Lin; +Cc: Shawn Guo, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
On Mon, Apr 01, 2013 at 10:48:13AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-mxs.c | 2 --
> 1 file changed, 2 deletions(-)
Both patches applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-02 9:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-01 2:48 [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip Axel Lin
2013-04-01 2:49 ` [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip Axel Lin
2013-04-01 3:52 ` Shiraz Hashim
2013-04-01 4:48 ` Viresh Kumar
2013-04-01 6:56 ` [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip Shawn Guo
2013-04-02 9:40 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox