From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Axel Lin <axel.lin@ingics.com>,
Bengt Jonsson <bengt.g.jonsson@stericsson.com>,
Yvan FILLION <yvan.fillion@stericsson.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: ab8500: Staticize ab8500_ext_regulator_[init|exit] if !CONFIG_REGULATOR_AB8500_EXT
Date: Tue, 2 Apr 2013 13:05:54 +0100 [thread overview]
Message-ID: <20130402120554.GB5580@gmail.com> (raw)
In-Reply-To: <20130402112740.GI23065@opensource.wolfsonmicro.com>
On Tue, 02 Apr 2013, Mark Brown wrote:
> On Tue, Apr 02, 2013 at 08:20:38AM +0800, Axel Lin wrote:
> > Fix below build errors:
> >
> > LD arch/arm/mach-ux500/built-in.o
> > arch/arm/mach-ux500/board-mop500-regulators.o: In function `ab8500_ext_regulator_init':
>
> Lee?
Ah yes, I see what's happened.
CONFIG_REGULATOR_AB8500_EXT was used to conditionally build the AB8500
External Regulator driver, but now we just 'build it anyway' on Mark's
request. However, the guards are still remaining in some places.
Please don't action this patch. I'll fix it up properly by removing
the surplus guards.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-04-02 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 0:20 [PATCH] regulator: ab8500: Staticize ab8500_ext_regulator_[init|exit] if !CONFIG_REGULATOR_AB8500_EXT Axel Lin
2013-04-02 11:27 ` Mark Brown
2013-04-02 11:45 ` Lee Jones
2013-04-02 11:51 ` Mark Brown
2013-04-02 12:05 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402120554.GB5580@gmail.com \
--to=lee.jones@linaro.org \
--cc=axel.lin@ingics.com \
--cc=bengt.g.jonsson@stericsson.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yvan.fillion@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox