From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933009Ab3DBTLl (ORCPT ); Tue, 2 Apr 2013 15:11:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48564 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932185Ab3DBTLk (ORCPT ); Tue, 2 Apr 2013 15:11:40 -0400 Date: Tue, 2 Apr 2013 15:11:30 -0400 From: Vivek Goyal To: Yinghai Lu Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , WANG Chao , "Eric W. Biederman" , Linux Kernel Mailing List Subject: Re: [PATCH 3/4] x86, kdump: Retore crashkernel= to allocate low Message-ID: <20130402191130.GB31760@redhat.com> References: <1364923183-316-1-git-send-email-yinghai@kernel.org> <1364923183-316-4-git-send-email-yinghai@kernel.org> <20130402180606.GI29506@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 02, 2013 at 11:49:13AM -0700, Yinghai Lu wrote: > On Tue, Apr 2, 2013 at 11:42 AM, Yinghai Lu wrote: > > aka: > > old kexec-tools stay with "crashkernel=X" > > new kexec-tools stay with > > 1. like old kexec tools > > 2. or "crashkernel=X,high" or "crashkernel=X,high crashkernel=Y,low", > > Y could be 100M or 0 etc. > > I keep the old logic like: > if there are several "crashkernel=X,high", only last one is honored. > if there are several "crashkernel=Y,low", only last one is honored. Yes but if different types of crashkernel= options are mixes then behavior is not defined. crashkernel=X,high crashkernel=X crashkernel=X,high crashkernel=Y;low crashkernel=Y;low crashkernel=X And possibilities go on. So I think it makes life simpler if we always parse last crashkernel= option and act upon that. And use crashkernel_no_auto_low to opt out of auto reserved low memory area. Thanks Vivek