From: Lee Jones <lee.jones@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Bengt Jonsson <bengt.g.jonsson@stericsson.com>,
Yvan FILLION <yvan.fillion@stericsson.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] regulator: ab8500: Fix 'match_size' undeclared and missing semicolon
Date: Wed, 3 Apr 2013 09:22:18 +0100 [thread overview]
Message-ID: <20130403082218.GC5580@gmail.com> (raw)
In-Reply-To: <1364956405.1328.4.camel@phoenix>
On Wed, 03 Apr 2013, Axel Lin wrote:
> Fix below build errors:
> CC drivers/regulator/ab8500.o
> drivers/regulator/ab8500.c: In function 'ab8500_regulator_probe':
> drivers/regulator/ab8500.c:3018:3: error: 'match_size' undeclared (first use in this function)
> drivers/regulator/ab8500.c:3018:3: note: each undeclared identifier is reported only once for each function it appears in
> drivers/regulator/ab8500.c:3019:2: error: expected ';' before '}' token
> drivers/regulator/ab8500.c:3036:2: error: expected ';' before '}' token
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/ab8500.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
> index bdd17e6..73d84d8 100644
> --- a/drivers/regulator/ab8500.c
> +++ b/drivers/regulator/ab8500.c
> @@ -3007,7 +3007,7 @@ static int ab8500_regulator_probe(struct platform_device *pdev)
> struct ab8500_regulator_info *regulator_info;
> int regulator_info_size;
> struct ab8500_reg_init *reg_init;
> - int reg_init_size;
> + int reg_init_size, match_size;
>
> if (is_ab9540(ab8500)) {
> regulator_info = ab9540_regulator_info;
> @@ -3015,7 +3015,7 @@ static int ab8500_regulator_probe(struct platform_device *pdev)
> reg_init = ab9540_reg_init;
> reg_init_size = AB9540_NUM_REGULATOR_REGISTERS;
> match = ab9540_regulator_match;
> - match_size = ARRAY_SIZE(ab9540_regulator_match)
> + match_size = ARRAY_SIZE(ab9540_regulator_match);
> } else if (is_ab8505(ab8500)) {
> regulator_info = ab8505_regulator_info;
> regulator_info_size = ARRAY_SIZE(ab8505_regulator_info);
> @@ -3032,7 +3032,7 @@ static int ab8500_regulator_probe(struct platform_device *pdev)
> reg_init = ab8500_reg_init;
> reg_init_size = AB8500_NUM_REGULATOR_REGISTERS;
> match = ab8500_regulator_match;
> - match_size = ARRAY_SIZE(ab8500_regulator_match)
> + match_size = ARRAY_SIZE(ab8500_regulator_match);
> }
>
> if (np) {
We already satisfy this requirement in:
"regulator: ab8500: Use a struct to select the good regulator
configuration"
... which is queued.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-04-03 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 2:30 [PATCH 1/4] regulator: ab8500: Remove set_voltage_time_sel and delay to fix build error Axel Lin
2013-04-03 2:32 ` [PATCH 2/4] regulator: ab8500: Remove voltages and voltages_len " Axel Lin
2013-04-03 2:33 ` [PATCH 3/4] regulator: ab8500: Fix 'match_size' undeclared and missing semicolon Axel Lin
2013-04-03 8:22 ` Lee Jones [this message]
2013-04-03 2:34 ` [PATCH 4/4] regulator: ab8500: Set match pointer and match_size for ab8505 and ab8540 Axel Lin
2013-04-03 8:24 ` Lee Jones
2013-04-03 17:42 ` [PATCH 1/4] regulator: ab8500: Remove set_voltage_time_sel and delay to fix build error Mark Brown
2013-04-03 22:01 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403082218.GC5580@gmail.com \
--to=lee.jones@linaro.org \
--cc=axel.lin@ingics.com \
--cc=bengt.g.jonsson@stericsson.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yvan.fillion@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox