Re: [PATCH 04/12] usb: phy: ab8500-usb: fix eye diagram for ab8500 v2.0

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 2460 bytes --]

On Wed, Apr 03, 2013 at 11:12:00AM +0200, Fabio Baltieri wrote:
> Hi Felipe,
> 
> On Wed, Apr 03, 2013 at 11:58:58AM +0300, Felipe Balbi wrote:
> > On Wed, Apr 03, 2013 at 11:53:36AM +0300, Felipe Balbi wrote:
> > > On Wed, Apr 03, 2013 at 10:45:05AM +0200, Fabio Baltieri wrote:
> > > > From: Sakethram Bommisetti <sakethram.bommisetti@stericsson.com>
> > > > 
> > > > AB8500 v2.0 has eye diagram issues when drawing more than 100mA from
> > > > VBUS.  Force charging current to 100mA in case of standard host.
> > > > 
> > > > Signed-off-by: Sakethram Bommisetti <sakethram.bommisetti@stericsson.com>
> > > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > > > Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
> > > > ---
> > > >  drivers/usb/phy/phy-ab8500-usb.c | 14 ++++++++++++++
> > > >  1 file changed, 14 insertions(+)
> > > > 
> > > > diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/phy/phy-ab8500-usb.c
> > > > index 5b92a59..1fd0780 100644
> > > > --- a/drivers/usb/phy/phy-ab8500-usb.c
> > > > +++ b/drivers/usb/phy/phy-ab8500-usb.c
> > > > @@ -485,6 +485,18 @@ static void ab8500_usb_phy_disable_work(struct work_struct *work)
> > > >  		ab8500_usb_peri_phy_dis(ab);
> > > >  }
> > > >  
> > > > +static unsigned ab8500_eyediagram_workaroud(struct ab8500_usb *ab, unsigned mA)
> > > > +{
> > > > +	/* AB8500 V2 has eye diagram issues when drawing more than 100mA from
> > > 
> > > wrong comment style. Please run *all* patches through checkpatch.pl
> > > --strict and sparse. I can wait 2 more hours before closing my tree for
> > > v3.10.
> > 
> > you know what ? this is simple enough, I'll fix it myself.
> 
> Ok, I was rushing a rebase but you've been faster! :-)
> 
> Anyway, paches were already sparse and checkpatch checked, but I ignored
> a warning for "mA" camelcase (as that's how it's commonly spelled for
> regulator) and new line indentation (where I used two-tabs instead of
> open parenthesis to be coherent with the rest of the source).
> 
> For comment style, checkpatch does not give me any warning for some
> reson.  The in-line open style is already used in the net/ subsystem so
> I was assuming that it was accepted here too.  If this is not the case
> maybe checkpatch.pl has to be fixed somehow.

right, only the net subsystem has this inline open style :-)

Nevermind, it was so minor that it didn't even hurt me :-p

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]