From: Vivek Goyal <vgoyal@redhat.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>, WANG Chao <chaowang@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] x86, kdump: Set crashkernel_low automatically
Date: Thu, 4 Apr 2013 10:11:16 -0400 [thread overview]
Message-ID: <20130404141116.GC16459@redhat.com> (raw)
In-Reply-To: <1365035906-3208-2-git-send-email-yinghai@kernel.org>
On Wed, Apr 03, 2013 at 05:38:23PM -0700, Yinghai Lu wrote:
[..]
> + if (ret != 0) {
> + /*
> + * two parts from lib/swiotlb.c:
> + * swiotlb size: user specified with swiotlb= or default.
> + * swiotlb overflow buffer: now is hardcoded to 32k,
> + * round to 8M to cover more others.
> + */
> + low_size = swiotlb_size_or_default() + (8UL<<20);
> + auto_set = true;
What is the correlation between swiotlb size of first kernel and second
kernel. They might be completely different kernel and with different
default size for swiotlb buffers.
[..]
>
> + crashkernel_low=size[KMG]
> + [KNL, x86_64] range under 4G. When crashkernel= is
> + passed, kernel allocate physical memory region
> + above 4G,
This is not right. "When crashkernel=X;high is passed kernel first tries
to allocate memory above 4G". crashkernel=X does not try to allocate
memory above 4G.
Vivek
next prev parent reply other threads:[~2013-04-04 14:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 0:38 [PATCH -v2 0/4] x86, kdump: Fix crashkernel high with old kexec-tools Yinghai Lu
2013-04-04 0:38 ` [PATCH v2 1/4] x86, kdump: Set crashkernel_low automatically Yinghai Lu
2013-04-04 8:11 ` HATAYAMA Daisuke
2013-04-04 16:45 ` Yinghai Lu
2013-04-04 14:11 ` Vivek Goyal [this message]
2013-04-04 16:28 ` Yinghai Lu
2013-04-04 0:38 ` [PATCH v2 3/4] kexec: use Crash kernel for Crash kernel low Yinghai Lu
2013-04-04 0:38 ` [PATCH v2 2/4] x86, kdump: Retore crashkernel= to allocate low Yinghai Lu
2013-04-04 14:16 ` Vivek Goyal
2013-04-04 16:56 ` Yinghai Lu
2013-04-04 0:38 ` [PATCH v2 4/4] x86, kdump: Change crashkernel_high/low= to crashkernel=;high/low Yinghai Lu
2013-04-04 6:55 ` HATAYAMA Daisuke
2013-04-04 17:33 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404141116.GC16459@redhat.com \
--to=vgoyal@redhat.com \
--cc=chaowang@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).