From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, Bill Pemberton <wfp5p@virginia.edu>,
Joe Perches <joe@perches.com>, Jonathan Cameron <jic23@cam.ac.uk>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH] staging/adt7316 Fix some 'interesting' string operations
Date: Fri, 5 Apr 2013 15:03:03 -0700 [thread overview]
Message-ID: <20130405220303.GA31802@kroah.com> (raw)
In-Reply-To: <515df29417437372eb@agluck-desk.sc.intel.com>
On Thu, Apr 04, 2013 at 02:37:24PM -0700, Luck, Tony wrote:
> Calling memcmp() to check the value of the first byte in a string is overkill.
> Just use buf[0] == '1' or buf[0] != '1' as appropriate.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
I'll let Jonathan take this through his tree which eventually makes it
to mine.
thanks,
greg k-h
next prev parent reply other threads:[~2013-04-05 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 21:37 [PATCH] staging/adt7316 Fix some 'interesting' string operations Luck, Tony
2013-04-05 22:03 ` Greg Kroah-Hartman [this message]
2013-04-06 10:08 ` Lars-Peter Clausen
2013-04-08 17:54 ` Luck, Tony
2013-04-09 17:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405220303.GA31802@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sonic.zhang@analog.com \
--cc=tony.luck@intel.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox