From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181Ab3DHGzt (ORCPT ); Mon, 8 Apr 2013 02:55:49 -0400 Received: from cassarossa.samfundet.no ([193.35.52.29]:50233 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277Ab3DHGzs (ORCPT ); Mon, 8 Apr 2013 02:55:48 -0400 Date: Mon, 8 Apr 2013 08:55:42 +0200 From: Hans-Christian Egtvedt To: Jiang Liu Cc: Jiang Liu , Haavard Skinnemoen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] AVR32: fix building warnings caused by redifinitions of HZ Message-ID: <20130408065542.GA28741@samfundet.no> References: <1365266616-8424-1-git-send-email-jiang.liu@huawei.com> <20130407075526.GA28026@samfundet.no> <516190CD.8040800@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <516190CD.8040800@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Around Sun 07 Apr 2013 23:29:17 +0800 or thereabout, Jiang Liu wrote: > On 04/07/2013 03:55 PM, Hans-Christian Egtvedt wrote: >> Around Sun 07 Apr 2013 00:43:36 +0800 or thereabout, Jiang Liu wrote: >>> Fix building warnings caused by redifinitions of HZ: >> Thanks for fixing. >> >>> Signed-off-by: Jiang Liu >>> Cc: Haavard Skinnemoen >>> Cc: Hans-Christian Egtvedt >>> Cc: linux-kernel@vger.kernel.org >> >> Acked-by: Hans-Christian Egtvedt >> >>> --- >>> arch/avr32/include/uapi/asm/param.h | 6 +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/avr32/include/uapi/asm/param.h b/arch/avr32/include/uapi/asm/param.h >>> index d28aa5e..abda103 100644 >>> --- a/arch/avr32/include/uapi/asm/param.h >>> +++ b/arch/avr32/include/uapi/asm/param.h >>> @@ -2,7 +2,11 @@ >>> #define _UAPI__ASM_AVR32_PARAM_H >>> >>> >>> -#ifndef HZ >>> +#ifndef __KERNEL__ >>> + /* >>> + * Technically, this is wrong, but some old apps still refer to it. >>> + * The proper way to get the HZ value is via sysconf(_SC_CLK_TCK). >>> + */ >> >> With this comment, are there AVR32 drivers/users that should be fixed? Or is >> it parts of the tree in general? > Hi Hans, > It's copied from arch/ia64/include/uapi/asm/param.h, I feel it should be > the same for AVR32 too. Most likely yes, the original param.h header file was added by David Howells from RedHat, and has never been touched since. Again, thanks for fixing. -- mvh Hans-Christian Egtvedt