From: Dave Chinner <david@fromorbit.com>
To: Phillip Susi <psusi@ubuntu.com>
Cc: Jens Axboe <axboe@kernel.dk>, CAI Qian <caiqian@redhat.com>,
xfs@oss.sgi.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]
Date: Tue, 9 Apr 2013 16:55:19 +1000 [thread overview]
Message-ID: <20130409065519.GH17758@dastard> (raw)
In-Reply-To: <515DE2FE.1080201@ubuntu.com>
On Thu, Apr 04, 2013 at 04:30:54PM -0400, Phillip Susi wrote:
> > I have not tested it yet, but I am pretty sure it won't work. It
> > looks like the patch changes the BLKRRPART path to go ahead and remove
> > existing partitions when GENHD_FL_NO_PARTSCAN is set. loop doesn't
> > issue the BLKRRPART ioctl when !LO_FLAGS_PARTSCAN so this won't help.
> > I think loop needs to set GENHD_FL_NO_PARTSCAN and then issue the
> > ioctl regardless of the LO_FLAGS_PARTSCAN flag to get the partitions
> > to be removed. I will try to test tonight.
>
> After testing, my initial thoughts appeared to have been correct. I had
> to modify the patch as follows. To test, simply do:
>
> truncate -s 10m img
> losetup /dev/loop0 img
> parted /dev/loop0
> mklabel msdos
> mkpart primary ext2 1m 2m
> quit
> ls /dev/loop0*
>
> Note the /dev/loop0p1 node. Run losetup -d /dev/loop0 and see if it is
> still there.
Jens, can we get one of these fixes merged quickly? xfstests is
unusable on any kernel more recent than 3.9-rc4 because of these
problems....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2013-04-09 6:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1462091996.435156.1364882416199.JavaMail.root@redhat.com>
2013-04-02 6:08 ` xfs deadlock on 3.9-rc5 running xfstests case #78 CAI Qian
2013-04-02 7:05 ` Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78] Dave Chinner
2013-04-02 7:19 ` Jens Axboe
2013-04-02 7:30 ` Jens Axboe
2013-04-02 8:39 ` CAI Qian
2013-04-02 9:00 ` Jens Axboe
2013-04-02 9:31 ` CAI Qian
2013-04-02 9:48 ` Jens Axboe
2013-04-03 11:41 ` Jens Axboe
2013-04-03 15:41 ` Phillip Susi
2013-04-04 20:30 ` Phillip Susi
2013-04-09 6:55 ` Dave Chinner [this message]
2013-04-09 7:01 ` Jens Axboe
2013-04-09 7:08 ` Dave Chinner
2013-04-10 7:24 ` Jens Axboe
2013-05-28 14:51 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409065519.GH17758@dastard \
--to=david@fromorbit.com \
--cc=axboe@kernel.dk \
--cc=caiqian@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=psusi@ubuntu.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox