From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Khalid Aziz <khalid.aziz@oracle.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, mce: Print warning if MCE handler fails to register /dev/mcelog
Date: Tue, 9 Apr 2013 20:52:21 +0200 [thread overview]
Message-ID: <20130409185221.GA5077@pd.tnic> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F1EA41C2B@ORSMSX104.amr.corp.intel.com>
On Tue, Apr 09, 2013 at 06:30:58PM +0000, Luck, Tony wrote:
> - misc_register(&mce_chrdev_device);
> + if (misc_register(&mce_chrdev_device) != 0)
> + pr_warn("Failed to register mcelog device\n");
>
> Did this actually happen to you? Or is this just "good practice" to check the
> return value from misc_register?
I'm very sceptical this actually happens - we would've otherwise seen
reports about mcelog not starting correctly.
Hmm.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-04-09 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 18:19 [PATCH] x86, mce: Print warning if MCE handler fails to register /dev/mcelog Khalid Aziz
2013-04-09 18:30 ` Luck, Tony
2013-04-09 18:52 ` Borislav Petkov [this message]
2013-04-09 19:20 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409185221.GA5077@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=khalid.aziz@oracle.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox