Re: [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

Michael R. Hines
2013-04-05T20:51:31Z

Sorry, I was wrong. ignore the comments about cgroups. That's still
broken. (i.e. trying to register RDMA memory while using a cgroup swap
limit cause the process get killed).

But the GIFT flag patch works (my understanding is that GIFT flag allows
the adapter to transmit stale memory information, it does not have
anything to do with cgroups specifically).

Am I missing something? I was only testing the GIFT flag patch.

Note: I only turned it on - I did not verify the (non) consitency of the
memory that was transmitted.

- Michael

On 04/05/2013 04:43 PM, Roland Dreier wrote:
> On Fri, Apr 5, 2013 at 1:17 PM, Michael R. Hines
> <mrhines@linux.vnet.ibm.com> wrote:
>> I also removed the IBV_*_WRITE flags on the sender-side and activated
>> cgroups with the "memory.memsw.limit_in_bytes" activated and the migration
>> with RDMA also succeeded without any problems (both with *and* without GIFT
>> also worked).
> Not sure I'm interpreting this correctly. Are you saying that things
> worked without actually setting the GIFT flag? In which case why are
> we adding this flag?
>
> - R.
>