From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@stericsson.com
Subject: Re: [PATCH 5/8] dmaengine: ste_dma40: Ensure src and dst registers are configured correctly
Date: Tue, 9 Apr 2013 22:38:07 +0200 [thread overview]
Message-ID: <201304092238.07286.arnd@arndb.de> (raw)
In-Reply-To: <20130409190916.GF25316@gmail.com>
On Tuesday 09 April 2013, Lee Jones wrote:
> On Tue, 09 Apr 2013, Arnd Bergmann wrote:
>
> > On Tuesday 09 April 2013, Lee Jones wrote:
> > > Confusingly d40_log_cfg() is used to set up the logical channel
> > > configuration registers, but d40_phy_cfg() is used to configure
> > > physical and logical registers, so it should be called in both
> > > cases. It is the function call's final attribute which determines
> > > whether it's a physical or logical channel, not whether the
> > > function is called or not.
> >
> > So how did it ever work? Your description sounds like it was
> > broken all along, but I would assume that someone tested the code.
>
> From what I can see, not.
>
> My best guess is that the 'test' was to see if the configuration
> changed using the debug print at the end of the function. I don't see
> how else the configuration can be written to hardware.
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2013-04-09 20:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 18:39 [PATCH 1/8] dmaengine: ste_dma40: Assign memcpy channels in the driver Lee Jones
2013-04-09 18:39 ` [PATCH 2/8] dmaengine: ste_dma40: Move default memcpy configs into " Lee Jones
2013-04-09 18:39 ` [PATCH 3/8] dmaengine: ste_dma40: Actually write the runtime configuration to registers Lee Jones
2013-04-09 18:59 ` Arnd Bergmann
2013-04-09 19:07 ` Lee Jones
2013-04-09 20:37 ` Arnd Bergmann
2013-04-12 13:49 ` Rabin Vincent
2013-04-12 16:13 ` Lee Jones
2013-04-15 11:06 ` Lee Jones
2013-04-15 11:36 ` Rabin Vincent
2013-04-15 11:59 ` Lee Jones
2013-04-15 13:47 ` Linus Walleij
2013-04-15 14:28 ` Lee Jones
2013-04-09 18:39 ` [PATCH 4/8] dmaengine: ste_dma40: Do not configure channels during an channel allocation Lee Jones
2013-04-12 13:54 ` Rabin Vincent
2013-04-12 16:38 ` Lee Jones
2013-04-14 16:34 ` Rabin Vincent
2013-04-09 18:39 ` [PATCH 5/8] dmaengine: ste_dma40: Ensure src and dst registers are configured correctly Lee Jones
2013-04-09 18:57 ` Arnd Bergmann
2013-04-09 19:09 ` Lee Jones
2013-04-09 20:38 ` Arnd Bergmann [this message]
2013-04-12 14:02 ` Rabin Vincent
2013-04-09 18:39 ` [PATCH 6/8] dmaengine: ste_dma40: Move LCPA allocation and real-time config Lee Jones
2013-04-09 18:56 ` Arnd Bergmann
2013-04-09 18:39 ` [PATCH 7/8] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 << x)'s Lee Jones
2013-04-09 18:55 ` Arnd Bergmann
2013-04-09 19:04 ` Harvey Harrison
2013-04-09 19:12 ` Arnd Bergmann
2013-04-10 9:34 ` Lee Jones
2013-04-10 12:22 ` Arnd Bergmann
2013-04-09 19:12 ` Lee Jones
2013-04-09 18:39 ` [PATCH 8/8] ARM: ux500: Amalgamate DMA source and destination channel numbers Lee Jones
2013-04-09 18:51 ` Arnd Bergmann
2013-04-24 13:45 ` [PATCH 1/8] dmaengine: ste_dma40: Assign memcpy channels in the driver Linus Walleij
[not found] ` <CAF2Aj3jHPvc=hOcgLq8LONppGtnxUPP96HRPLfCwQ5x4HONUOw@mail.gmail.com>
2013-04-24 15:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304092238.07286.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox