From: Michal Marek <mmarek@suse.cz>
To: Darren Hart <dvhart@linux.intel.com>
Cc: John Stultz <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Bruce Ashfield <bruce.ashfield@windriver.com>
Subject: Re: [PATCH] merge_config.sh: Avoid creating unnessary source softlinks
Date: Wed, 10 Apr 2013 10:57:18 +0200 [thread overview]
Message-ID: <20130410085718.GA17541@sepie.suse.cz> (raw)
In-Reply-To: <515EED40.9000102@linux.intel.com>
On Fri, Apr 05, 2013 at 08:26:56AM -0700, Darren Hart wrote:
>
>
> On 04/04/2013 12:02 PM, John Stultz wrote:
> > Viresh noticed when using merge_config.sh that a source softlink
> > was being created even when he didn't specify the -O option.
> >
> > The problem arises due to the previous commit 409f117e2d6b
> > which added the -O option. Basically if -O is not specified,
> > we still pass '-O=.' to the make command, which then generates
> > a source softlink to ./
> >
> > This patch adds an extra check so if there is no -O specified
> > to merge_config.sh, we don't pass one on to make.
> >
> > Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Cc: Michal Marek <mmarek@suse.cz>
> > Cc: Bruce Ashfield <bruce.ashfield@windriver.com>
> > Cc: Darren Hart <dvhart@linux.intel.com>
> > Reported-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Tested-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Signed-off-by: John Stultz <john.stultz@linaro.org>
>
> Thanks John!
>
> Acked-by: Darren Hart <dvhart@linux.intel.com>
Added to kbuild.git#kconfig.
Michal
prev parent reply other threads:[~2013-04-10 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 19:02 [PATCH] merge_config.sh: Avoid creating unnessary source softlinks John Stultz
2013-04-05 15:26 ` Darren Hart
2013-04-10 8:57 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410085718.GA17541@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=bruce.ashfield@windriver.com \
--cc=dvhart@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox