From: Jacob Shin <jacob.shin@amd.com>
To: Stephane Eranian <eranian@google.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>, x86 <x86@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND 0/3] perf, amd: Support for Family 16h L2I Performance Counters
Date: Wed, 10 Apr 2013 10:03:19 -0500 [thread overview]
Message-ID: <20130410150319.GA10089@jshin-Toonie> (raw)
In-Reply-To: <CABPqkBQ6Nzz91pzshgt1i63tjJ+3QHAuiVgKXd_RQypoeyqx6Q@mail.gmail.com>
On Wed, Apr 10, 2013 at 02:29:44PM +0200, Stephane Eranian wrote:
> On Wed, Apr 10, 2013 at 2:28 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Stephane Eranian <eranian@google.com> wrote:
> >
> >> On Wed, Apr 10, 2013 at 1:56 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >> >
> >> > * Peter Zijlstra <peterz@infradead.org> wrote:
> >> >
> >> >> On Wed, 2013-04-10 at 13:49 +0200, Peter Zijlstra wrote:
> >> >>
> >> >> > Hmm.. the 15h old interface bits got merged? I thought I kept telling
> >> >> > that should be done like the intel uncore stuff since the hardware
> >> >> > interface wasn't retarded anymore.
> >> >>
> >> >> Ah well, that crap seems to have slipped in in Feb when I was still a
> >> >> near vegetable and not paying much attention.
> >> >>
> >> >> /me curses a bit.
> >> >>
> >> >> I don't suppose we can deprecate it and remove this stuff?
> >> >
> >> > I think we can - if there's a functional replacement.
> >> >
> >> Does the existing code expose a type in sysfs?
It does not.
> >> If not then you cannot do this transparently, I am afraid
> >> because the syntax would be different, i.e., not cpu/...
> >
> > That could be compatibility-bridged over in tooling?
> >
> > I doubt these events are in heavy use.
> >
> I agree.
Right, I don't think they are.
>
> >> I reviewed the code and tested it. But at the time, I thought
> >> you had agreed on the approach used.
> >
> > I did - but PeterZ has a point, so it would be nice if we could improve on that.
> >
> I think it is doable by cloning some of the functions into an amd_unc.c file.
>
Sigh .. okay ....
next prev parent reply other threads:[~2013-04-10 15:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 15:23 [PATCH RESEND 0/3] perf, amd: Support for Family 16h L2I Performance Counters Jacob Shin
2013-04-09 15:23 ` [PATCH RESEND 1/3] perf, amd: Further generalize NB event constraints handling logic Jacob Shin
2013-04-09 15:23 ` [PATCH RESEND 2/3] perf, x86: Allow for multiple kfree_on_online pointers Jacob Shin
2013-04-09 15:23 ` [PATCH RESEND 3/3] perf, amd: Enable L2I performance counters on AMD Family 16h Jacob Shin
2013-04-10 9:41 ` [PATCH RESEND 0/3] perf, amd: Support for Family 16h L2I Performance Counters Peter Zijlstra
2013-04-10 9:48 ` Peter Zijlstra
2013-04-10 11:38 ` Stephane Eranian
2013-04-10 11:49 ` Peter Zijlstra
2013-04-10 11:52 ` Stephane Eranian
2013-04-10 11:55 ` Peter Zijlstra
2013-04-10 11:56 ` Ingo Molnar
2013-04-10 12:12 ` Stephane Eranian
2013-04-10 12:28 ` Ingo Molnar
2013-04-10 12:29 ` Stephane Eranian
2013-04-10 15:03 ` Jacob Shin [this message]
2013-04-10 12:29 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410150319.GA10089@jshin-Toonie \
--to=jacob.shin@amd.com \
--cc=acme@ghostprotocols.net \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox