From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Anton Vorontsov <cbou@mail.ru>, Keerthy <j-keerthy@ti.com>,
Kyle Manna <kyle@kylemanna.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion
Date: Wed, 10 Apr 2013 10:00:26 -0700 [thread overview]
Message-ID: <20130410170026.GZ10155@atomide.com> (raw)
In-Reply-To: <201304101612.51620@pali>
* Pali Rohár <pali.rohar@gmail.com> [130410 07:17]:
> On Monday 08 April 2013 20:15:24 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@gmail.com> [130404 02:37]:
> > > On Sunday 24 March 2013 15:03:29 Pali Rohár wrote:
> > > > On Saturday 02 March 2013 23:23:05 Pali Rohár wrote:
> > > > > On Friday 15 February 2013 23:56:49 Pali Rohár wrote:
> > > > > > Driver twl4030-madc has hardcoded channel types (10 -
> > > > > > battery current, 1 - battery temperature) and also
> > > > > > conversation data in variable twl4030_divider_ratios.
> > > > > > These hardcoded channels are incorrect for Nokia RX-51
> > > > > > board (where is channel 0 - battery temperature).
> > > > > >
> > > > > > For Nokia RX-51 there is rx51_battery power_supply
> > > > > > driver which reporting battery information via
> > > > > > twl4030_madc_conversion. But this driver needs raw
> > > > > > values (not converted via some hardcoded functions).
> > > > > > So this patch adding new parameter "raw" to struct
> > > > > > twl4030_madc_request which tell twl4030-madc driver to
> > > > > > not convert values, but rather return raw.
> > > > > >
> > > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > > > > ---
> > > > > >
> > > > > > drivers/mfd/twl4030-madc.c | 14
> > > > > > ++++++++++---- include/linux/i2c/twl4030-madc.h |
> > > > > > 2 ++
> > > > > > 2 files changed, 12 insertions(+), 4 deletions(-)
> > > > >
> > > > > Hello, can somebody review this twl4030-madc patch?
> > > >
> > > > Bump.
> > > >
> > > > Can some of mfd maintainers look at this patch and include
> > > > it to mfd tree? It is needed for rx51_battery power
> > > > supply driver.
> > >
> > > CCing Tony, can you look at this patch?
> >
> > Sorry for the delay in replying, I've been going through my
> > inbox for the merge window and noticed this.
> >
> > I suggest resend with Peter Ujfalusi cc:d as he is the
> > de-facto twl/tps maintainer and expert by now.
> >
> > Regards,
> >
> > Tony
>
> Ok, both patches are now in mfd-next tree.
Great thanks!
Tony
next prev parent reply other threads:[~2013-04-10 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 22:56 [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion Pali Rohár
2013-02-15 22:56 ` [PATCH 2/2] power: rx51_battery: Fix reporting correct values Pali Rohár
2013-02-16 21:39 ` Anton Vorontsov
2013-03-02 22:23 ` [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion Pali Rohár
2013-03-24 14:03 ` Pali Rohár
2013-04-04 9:32 ` Pali Rohár
2013-04-08 18:15 ` Tony Lindgren
2013-04-10 14:12 ` Pali Rohár
2013-04-10 17:00 ` Tony Lindgren [this message]
2013-04-04 9:38 ` Samuel Ortiz
2013-04-08 10:43 ` Pali Rohár
2013-03-02 23:16 ` Anton Vorontsov
2013-04-08 14:34 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410170026.GZ10155@atomide.com \
--to=tony@atomide.com \
--cc=cbou@mail.ru \
--cc=j-keerthy@ti.com \
--cc=kyle@kylemanna.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox