From: Greg KH <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [char-misc-next 1/3] mei: nfc: Initial nfc implementation
Date: Wed, 10 Apr 2013 10:25:51 -0700 [thread overview]
Message-ID: <20130410172551.GA1881@kroah.com> (raw)
In-Reply-To: <1365464495-17642-2-git-send-email-tomas.winkler@intel.com>
On Tue, Apr 09, 2013 at 02:41:33AM +0300, Tomas Winkler wrote:
> From: Samuel Ortiz <sameo@linux.intel.com>
>
> NFC ME device is exported through the MEI bus to be consumed by the
> NFC subsystem.
>
> NFC is represented by two mei clients: An info one and the actual
> NFC one. In order to properly build the ME id we first need to retrieve
> the firmware information from the info client and then disconnect from it.
I still don't understand why you aren't tieing this into the existing
nfc kernel api. What am I missing?
>
> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/misc/mei/Makefile | 1 +
> drivers/misc/mei/client.c | 3 +
> drivers/misc/mei/init.c | 2 +
> drivers/misc/mei/mei_dev.h | 10 ++
> drivers/misc/mei/nfc.c | 250 ++++++++++++++++++++++++++++++++++++++++++
> include/uapi/linux/Kbuild | 1 +
> include/uapi/linux/mei/Kbuild | 2 +
> include/uapi/linux/mei/nfc.h | 135 +++++++++++++++++++++++
Based on our previous off-list emails, you said that this .h file is
needed for the userspace api. But the nfc userspace api is through the
nfc API, which doesn't use any of the structures defined here. So who
exactly uses this file?
confused,
greg k-h
next prev parent reply other threads:[~2013-04-10 17:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 23:41 [char-misc-next 0/3 V6] Support NFC Device on MEI CL Bus Tomas Winkler
2013-04-08 23:41 ` [char-misc-next 1/3] mei: nfc: Initial nfc implementation Tomas Winkler
2013-04-10 17:25 ` Greg KH [this message]
2013-04-10 19:19 ` Samuel Ortiz
2013-04-10 19:46 ` Arnd Bergmann
2013-04-10 20:03 ` Greg KH
2013-04-10 21:15 ` Samuel Ortiz
2013-04-10 22:29 ` Arnd Bergmann
2013-04-10 22:52 ` Samuel Ortiz
2013-04-10 22:59 ` Greg KH
2013-04-08 23:41 ` [char-misc-next 2/3] mei: nfc: Add NFC device to the MEI bus Tomas Winkler
2013-04-08 23:41 ` [char-misc-next 3/3] mei: nfc: Implement MEI bus ops Tomas Winkler
2013-04-09 0:08 ` [char-misc-next 0/3 V6] Support NFC Device on MEI CL Bus Greg KH
2013-04-09 13:12 ` Winkler, Tomas
2013-04-09 13:46 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410172551.GA1881@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox