From: Greg KH <gregkh@linuxfoundation.org>
To: KY Srinivasan <kys@microsoft.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Add additional distro specific Kconfig options
Date: Wed, 10 Apr 2013 10:50:25 -0700 [thread overview]
Message-ID: <20130410175025.GA4644@kroah.com> (raw)
In-Reply-To: <a6d2f8d7a9bf48cda759bf7029192c4d@SN2PR03MB061.namprd03.prod.outlook.com>
On Wed, Apr 10, 2013 at 05:37:41PM +0000, KY Srinivasan wrote:
> You are reading more into this than there is. As it stands now
> (without this patch), the code that constructs the guest OS ID has
> place holders for adding in some distro specific tags into this ID.
I understand that, the fact that you now want this to be a configurable
value at build time, yet provide exactly NO information to anyone as to
what to set the values to, what the values mean, or anything else about
these values this is why I am rejecting this patch.
If you are already properly handling os-release, then there is no need
for these values to mean anything for a Linux guest, as it would be
totally redundant, and probably wrong (hint, the same kernel binary can
be running on different os userspace layers.)
sorry,
greg k-h
prev parent reply other threads:[~2013-04-10 17:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 16:08 [PATCH 1/1] Drivers: hv: vmbus: Add additional distro specific Kconfig options K. Y. Srinivasan
2013-04-10 15:49 ` Greg KH
2013-04-10 16:12 ` KY Srinivasan
2013-04-10 16:33 ` Greg KH
2013-04-10 17:37 ` KY Srinivasan
2013-04-10 17:50 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410175025.GA4644@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox