RE: [PATCH 1/1] Drivers: hv: vmbus: Add additional distro specific Kconfig options

KY Srinivasan
2013-04-10T16:14:48Z

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Wednesday, April 10, 2013 11:50 AM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com
> Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Add additional distro specific Kconfig
> options
>
> On Wed, Apr 10, 2013 at 09:08:17AM -0700, K. Y. Srinivasan wrote:
> > The guest ID captures information about the guest and has room for
> > distributions to add distro specific information. Add Kconfig options
> > to support distro specific information to be managed easily.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> > drivers/hv/Kconfig | 14 ++++++++++++++
> > drivers/hv/hv.c | 4 +++-
> > drivers/hv/hyperv_vmbus.h | 2 +-
> > 3 files changed, 18 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
> > index 0403b51..d2ca9c7 100644
> > --- a/drivers/hv/Kconfig
> > +++ b/drivers/hv/Kconfig
> > @@ -19,4 +19,18 @@ config HYPERV_BALLOON
> > help
> > Select this option to enable Hyper-V Balloon driver.
> >
> > +config HYPERV_GUEST_D1
> > + hex "Distro specific information"
> > + range 0x00 0xff
> > + default 0
> > + help
> > + This specifies the Distro vendor
>
> And just what is a distro supposed to set the value here to? For
> example, what would Arch Linux pick? Fedora? RHEL? SLES? openSUSE?
> You do know that there are more than 0xff different Linux distro
> "vendors"? Do they all just get to pick a number that they like?

MSFT is planning to manage this space; we will assign distributions unique numbers
that they can use here.

>
> > +config HYPERV_GUEST_D2
> > + hex "Additional Distro specific information"
> > + range 0x0000 0xffff
> > + default 0
> > + help
> > + Additional Distro specific kernel version information
>
> Again, what is a distro supposed to do here? What's wrong with the
> kernel version information that the kernel already has? Can't you just
> use that string?

We already have the kernel version information. Distros can choose to use this
as they please. We are recommending that they use this field to track some distro specific
build number.

Regards,

K. Y