Re: [PATCH 1/1] Drivers: hv: vmbus: Add additional distro specific Kconfig options

Greg KH
2013-04-10T17:50:28Z

On Wed, Apr 10, 2013 at 05:37:41PM +0000, KY Srinivasan wrote:
> You are reading more into this than there is. As it stands now
> (without this patch), the code that constructs the guest OS ID has
> place holders for adding in some distro specific tags into this ID.

I understand that, the fact that you now want this to be a configurable
value at build time, yet provide exactly NO information to anyone as to
what to set the values to, what the values mean, or anything else about
these values this is why I am rejecting this patch.

If you are already properly handling os-release, then there is no need
for these values to mean anything for a Linux guest, as it would be
totally redundant, and probably wrong (hint, the same kernel binary can
be running on different os userspace layers.)

sorry,

greg k-h