From: Vivek Goyal <vgoyal@redhat.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>, WANG Chao <chaowang@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -v4 0/4] x86, kdump: Fix crashkernel high with old kexec-tools
Date: Wed, 10 Apr 2013 16:28:42 -0400 [thread overview]
Message-ID: <20130410202842.GG6602@redhat.com> (raw)
In-Reply-To: <1365622759-2133-1-git-send-email-yinghai@kernel.org>
On Wed, Apr 10, 2013 at 12:39:15PM -0700, Yinghai Lu wrote:
> Vivek found some problems with old kexec-tools.
>
> We keep the old crashkernel=X to old behavoir, so it will not break
> old kexec-tools.
> Add crashkernel=X,high to support new kexec-tools that supports loading high.
> when high is used, memblock will search from top to low.
> if the allocated one is above 4G, kernel will try to auto allocate
> 72M under 4G for swiotlb.
> user could crashkernel=Y,low to change 72M to other value.
>
> -v2: reorder the patch sequences
> crashkernel=X,high, crashkernel=Y,low only handle simple form.
> crashkernel=X will override crashkernel=X;high crashkernel=Y;low
> -v3: update description in kernel-parameters.txt
> update get_last_crashkernel and _simple checking about suffix.
> -v4: update to use ,high again, and also not abuse parse_crashkernel_simple
>
This series looks good to me.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
prev parent reply other threads:[~2013-04-10 20:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 19:39 [PATCH -v4 0/4] x86, kdump: Fix crashkernel high with old kexec-tools Yinghai Lu
2013-04-10 19:39 ` [PATCH v4 1/4] x86, kdump: Set crashkernel_low automatically Yinghai Lu
2013-04-10 19:39 ` [PATCH v4 4/4] kexec: use Crash kernel for Crash kernel low Yinghai Lu
2013-04-10 19:39 ` [PATCH v4 2/4] x86, kdump: Retore crashkernel= to allocate under 896M Yinghai Lu
2013-04-10 19:39 ` [PATCH v4 3/4] x86, kdump: Change crashkernel_high/low= to crashkernel=,high/low Yinghai Lu
2013-04-12 5:46 ` HATAYAMA Daisuke
2013-04-12 6:26 ` Yinghai Lu
2013-04-10 20:28 ` Vivek Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410202842.GG6602@redhat.com \
--to=vgoyal@redhat.com \
--cc=chaowang@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox