From: Ingo Molnar <mingo@kernel.org>
To: Waiman Long <Waiman.Long@hp.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Dave Jones <davej@redhat.com>,
Clark Williams <williams@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Davidlohr Bueso <davidlohr.bueso@hp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Chandramouleeswaran, Aswin" <aswin@hp.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrew Morton <akpm@linux-foundation.org>,
"Norton, Scott J" <scott.norton@hp.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH RFC 1/3] mutex: Make more scalable by doing less atomic operations
Date: Thu, 11 Apr 2013 11:07:17 +0200 [thread overview]
Message-ID: <20130411090717.GA14491@gmail.com> (raw)
In-Reply-To: <5165D8F4.7010701@hp.com>
* Waiman Long <Waiman.Long@hp.com> wrote:
> BTW, I have also been thinking about extracting the spinlock out from the mutex
> structure for some busy mutex by adding a pointer to an external auxiliary
> structure (separately allocated at init time). The idea is to use the external
> spinlock if available. Otherwise, the internal one will be used. That should
> reduce cacheline contention for some of the busiest mutex. The spinner queuing
> tickets can be in the external structure too. However, it requires a one line
> change in each of the mutex initialization code. I haven't actually made the
> code change and try it yet, but that is something that I am thinking of doing
> when I have time.
I'm not sure per mutex allocations are a really good idea - we like our locking
primitives to be simple, embeddable into data structures and allocatable together
with the data structure with no other separate memory footprint.
Thanks,
Ingo
next prev parent reply other threads:[~2013-04-11 9:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 14:54 [PATCH RFC 0/3] mutex: Improve mutex performance by doing less atomic-ops & spinning Waiman Long
2013-04-04 14:54 ` [PATCH RFC 1/3] mutex: Make more scalable by doing less atomic operations Waiman Long
2013-04-08 12:42 ` Ingo Molnar
2013-04-08 14:38 ` Linus Torvalds
2013-04-08 15:09 ` Ingo Molnar
2013-04-08 17:53 ` Waiman Long
2013-04-10 10:31 ` Ingo Molnar
2013-04-10 15:52 ` Waiman Long
2013-04-10 17:16 ` Ingo Molnar
2013-04-10 21:26 ` Waiman Long
2013-04-11 9:07 ` Ingo Molnar [this message]
2013-04-10 14:09 ` Robin Holt
2013-04-10 15:46 ` Linus Torvalds
2013-04-08 17:42 ` Waiman Long
2013-04-10 10:28 ` Ingo Molnar
2013-04-10 15:47 ` Waiman Long
2013-04-04 14:54 ` [PATCH RFC 2/3] mutex: restrict mutex spinning to only one task per mutex Waiman Long
2013-04-04 14:54 ` [PATCH RFC 3/3] mutex: dynamically disable mutex spinning at high load Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411090717.GA14491@gmail.com \
--to=mingo@kernel.org \
--cc=Waiman.Long@hp.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=aswin@hp.com \
--cc=davej@redhat.com \
--cc=davidlohr.bueso@hp.com \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).