public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] RAPL (Running Average Power Limit) driver
@ 2013-04-05 21:02 Jacob Pan
  2013-04-05 21:02 ` [PATCH v2] Introduce Intel RAPL cooling device driver Jacob Pan
  2013-04-05 21:06 ` [PATCH v2] RAPL (Running Average Power Limit) driver Greg Kroah-Hartman
  0 siblings, 2 replies; 9+ messages in thread
From: Jacob Pan @ 2013-04-05 21:02 UTC (permalink / raw)
  To: LKML, Platform Driver, Matthew Garrett
  Cc: Zhang Rui, Rafael Wysocki, Len Brown, Srinivas Pandruvada,
	Arjan van de Ven, Greg Kroah-Hartman, Joe Perches, Randy Dunlap,
	Paul Bolle, Jacob Pan

Changes since V2:
	- use 'struct device' instead of raw kobject to represent
	  RAPL domains
	- changed eventfd control interface to use event string
	  instead of passing file descriptors that cannot be
	  authenticated in sysfs directory
	- clean ups based on v1 reviews
		- use kcalloc for arrays
		- drop dependencies on X86
		- misc cleanups

I don have a checkpatch error which I think it is not valid. I can
fix it by avoiding the macro/adding more lines.

ERROR: Macros with complex values should be enclosed in parenthesis
#735: FILE: platform/x86/intel_rapl.c:735:
+#define RO_PRIMITIVE(name)						\
+	primitive_show_fn(name)						\
+	static DEVICE_ATTR(name, S_IRUGO, show_##name, NULL)

If i put parenthesis around it to mute the error then it won't compile.

I attempted to come up with a simple version as Greg suggested to
just expose cooling device but then I realized we could lose many
key functionalities partially due to the correlations among RAPL
control knobs. I am still working on this since it is not as simple as
deleting the advanced interfaces, I would have to do some setup based
on best guesses.

Jacob Pan (1):
  Introduce Intel RAPL cooling device driver

 Documentation/ABI/testing/sysfs-class-intel-rapl |  121 ++
 drivers/platform/x86/Kconfig                     |    9 +
 drivers/platform/x86/Makefile                    |    1 +
 drivers/platform/x86/intel_rapl.c                | 1285 ++++++++++++++++++++++
 drivers/platform/x86/intel_rapl.h                |  244 ++++
 5 files changed, 1660 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-intel-rapl
 create mode 100644 drivers/platform/x86/intel_rapl.c
 create mode 100644 drivers/platform/x86/intel_rapl.h

-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2013-04-12 15:39 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-05 21:02 [PATCH v2] RAPL (Running Average Power Limit) driver Jacob Pan
2013-04-05 21:02 ` [PATCH v2] Introduce Intel RAPL cooling device driver Jacob Pan
2013-04-05 21:06   ` Greg Kroah-Hartman
2013-04-05 21:26   ` Joe Perches
2013-04-05 21:35     ` Greg Kroah-Hartman
2013-04-12 15:32       ` Jacob Pan
2013-04-12 15:39         ` Greg Kroah-Hartman
2013-04-05 21:57     ` Jacob Pan
2013-04-05 21:06 ` [PATCH v2] RAPL (Running Average Power Limit) driver Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox