Re: [PATCH] regulator: ab8500: Fix get_mode for shared mode regulators

Mark Brown
2013-04-15T16:07:31Z

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Mon, Apr 15, 2013 at 04:48:03PM +0200, Bengt Jönsson wrote:

> Reverting 500b4ac90d1103 makes sense, but first I want to mention
> two things:

> 1. In some cases it is not even possible to know the actual current
> state of a regulator because it is controlled by HW as well as SW.
> We have several examples of this.

If we're getting diverging statuses here then we need to introduce a
separate function to report the actual hardware state. The get/set
should be the request.

> 2. regulator_enable/disable also checks the current status before
> setting the regulator. Should these checks be removed as well?

No, the enable state should reflect the state of the request from the
AP. regulator_get_status() should return the actual physical state.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]