From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138Ab3DONao (ORCPT ); Mon, 15 Apr 2013 09:30:44 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:47838 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650Ab3DONam (ORCPT ); Mon, 15 Apr 2013 09:30:42 -0400 From: Grant Likely Subject: Re: [PATCH] clk: add DT test clock consumer driver To: Sebastian Hesselbarth , Sebastian Hesselbarth Cc: Rob Herring , Rob Landley , Mike Turquette , Linus Walleij , Arnd Bergmann , Andrew Morton , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <1363439376-21294-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1363439376-21294-1-git-send-email-sebastian.hesselbarth@gmail.com> Date: Mon, 15 Apr 2013 14:30:38 +0100 Message-Id: <20130415133038.2A7723E0AA8@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 Mar 2013 14:09:36 +0100, Sebastian Hesselbarth wrote: > This driver adds a DT test clock consumer that exposes debugfs files to > enable/disable and set/get rate of the attached programmable clock. > During development of a i2c-attached clock generator I found it useful > to debug the clock generator's internal pll settings by enforcing clock > rates through debugfs. > > Signed-off-by: Sebastian Hesselbarth Rather that using a DT binding to enable this, would it not be better to have the debug interface bound entirely at runtime, and be able to attach to pretty much any clock. It is less usable if it requires modifying the dtb to use a debug feature. g.