From: Robin Holt <holt@sgi.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Robin Holt <holt@sgi.com>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russ Anderson <rja@sgi.com>, Shawn Guo <shawn.guo@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
the arch/x86 maintainers <x86@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <laijs@cn.fujitsu.com>,
Michel Lespinasse <walken@google.com>,
"rusty@rustcorp.com.au" <rusty@rustcorp.com.au>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: Bulk CPU Hotplug (Was Re: [PATCH] Do not force shutdown/reboot to boot cpu.)
Date: Mon, 15 Apr 2013 11:04:08 -0500 [thread overview]
Message-ID: <20130415160408.GA3658@sgi.com> (raw)
In-Reply-To: <20130413163022.GA7500@redhat.com>
On Sat, Apr 13, 2013 at 06:30:22PM +0200, Oleg Nesterov wrote:
> On 04/12, Robin Holt wrote:
> >
> > +void migrate_to_boot_cpu(void)
> > +{
> > + /* The boot cpu is always logical cpu 0 */
> > + int reboot_cpu_id = 0;
> > +
> > + /* Make certain the cpu I'm about to reboot on is online */
> > + if (!cpu_online(reboot_cpu_id))
> > + reboot_cpu_id = smp_processor_id();
> > +
> > + /* Make certain I only run on the appropriate processor */
> > + set_cpus_allowed_ptr(current, cpumask_of(reboot_cpu_id));
>
> This is only theoretical, but perhaps it makes sense to set
> PF_THREAD_BOUND before set_cpus_allowed_ptr() ? To prevent the
> race with another thread doing sched_setaffinity().
I don't quite understand this comment. We are migrating our own thread.
How does setting PF_THREAD_BOUND have any effect?
Robin
next prev parent reply other threads:[~2013-04-15 16:04 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 19:37 [PATCH] Do not force shutdown/reboot to boot cpu Robin Holt
2013-04-08 15:57 ` Ingo Molnar
2013-04-08 16:11 ` H. Peter Anvin
2013-04-08 16:59 ` Robin Holt
2013-04-10 11:16 ` Ingo Molnar
2013-04-10 14:01 ` Robin Holt
2013-04-10 15:10 ` Linus Torvalds
2013-04-10 15:29 ` Russ Anderson
2013-04-10 16:59 ` Ingo Molnar
2013-04-10 17:14 ` Robin Holt
2013-04-10 17:22 ` Ingo Molnar
2013-04-10 17:55 ` Robin Holt
2013-04-10 19:00 ` Robin Holt
2013-04-11 8:57 ` Ingo Molnar
2013-04-11 11:34 ` Robin Holt
2013-04-11 12:00 ` Ingo Molnar
2013-04-11 12:03 ` Robin Holt
2013-04-11 12:08 ` Robin Holt
2013-04-11 12:14 ` Ingo Molnar
2013-04-10 17:58 ` H. Peter Anvin
2013-04-10 23:02 ` Russ Anderson
2013-04-10 22:29 ` Russ Anderson
2013-04-11 5:31 ` Paul Mackerras
2013-04-11 12:45 ` Bulk CPU Hotplug (Was Re: [PATCH] Do not force shutdown/reboot to boot cpu.) Srivatsa S. Bhat
2013-04-11 13:48 ` Robin Holt
2013-04-12 5:37 ` Ingo Molnar
2013-04-12 6:09 ` Srivatsa S. Bhat
2013-04-12 9:31 ` Robin Holt
2013-04-12 10:01 ` Robin Holt
2013-04-13 16:30 ` Oleg Nesterov
2013-04-15 16:04 ` Robin Holt [this message]
2013-04-15 16:09 ` Oleg Nesterov
2013-04-15 16:10 ` Robin Holt
2013-04-13 17:01 ` Srivatsa S. Bhat
2013-04-15 10:16 ` Ingo Molnar
2013-04-15 12:02 ` Robin Holt
2013-04-15 15:59 ` Robin Holt
2013-04-16 9:40 ` Ingo Molnar
2013-04-11 14:23 ` Russ Anderson
2013-04-11 14:45 ` Srivatsa S. Bhat
2013-04-11 20:08 ` Russ Anderson
2013-04-11 20:17 ` Srivatsa S. Bhat
2013-04-11 21:08 ` Robin Holt
2013-04-08 16:54 ` [PATCH] Do not force shutdown/reboot to boot cpu Robin Holt
2013-04-08 17:07 ` Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415160408.GA3658@sgi.com \
--to=holt@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rja@sgi.com \
--cc=rusty@rustcorp.com.au \
--cc=shawn.guo@linaro.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox