From: Mark Brown <broonie@kernel.org>
To: "Bengt Jönsson" <bengt.g.jonsson@stericsson.com>
Cc: Axel Lin <axel.lin@ingics.com>, Lee Jones <lee.jones@linaro.org>,
Yvan FILLION <yvan.fillion@stericsson.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: ab8500: Fix get_mode for shared mode regulators
Date: Mon, 15 Apr 2013 17:07:26 +0100 [thread overview]
Message-ID: <20130415160726.GF15837@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <516C1323.9060302@stericsson.com>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
On Mon, Apr 15, 2013 at 04:48:03PM +0200, Bengt Jönsson wrote:
> Reverting 500b4ac90d1103 makes sense, but first I want to mention
> two things:
> 1. In some cases it is not even possible to know the actual current
> state of a regulator because it is controlled by HW as well as SW.
> We have several examples of this.
If we're getting diverging statuses here then we need to introduce a
separate function to report the actual hardware state. The get/set
should be the request.
> 2. regulator_enable/disable also checks the current status before
> setting the regulator. Should these checks be removed as well?
No, the enable state should reflect the state of the request from the
AP. regulator_get_status() should return the actual physical state.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-04-15 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 12:31 [PATCH] regulator: ab8500: Fix get_mode for shared mode regulators Axel Lin
2013-04-13 14:10 ` Axel Lin
2013-04-15 8:09 ` Lee Jones
2013-04-15 8:03 ` Bengt Jönsson
2013-04-15 8:34 ` Axel Lin
2013-04-15 8:50 ` Axel Lin
2013-04-15 11:34 ` Bengt Jönsson
2013-04-15 12:13 ` Axel Lin
2013-04-15 12:41 ` Bengt Jönsson
2013-04-15 14:11 ` Axel Lin
2013-04-15 14:48 ` Bengt Jönsson
2013-04-15 16:07 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415160726.GF15837@opensource.wolfsonmicro.com \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=bengt.g.jonsson@stericsson.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yvan.fillion@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox