public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-input@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	Simon Glass <sjg@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: Export matrix_keypad_parse_of_params()
Date: Mon, 15 Apr 2013 09:07:47 -0700	[thread overview]
Message-ID: <20130415160747.GA19223@core.coreip.homeip.net> (raw)
In-Reply-To: <1366027608-17395-1-git-send-email-mmarek@suse.cz>

Hi Michal,

On Mon, Apr 15, 2013 at 02:06:48PM +0200, Michal Marek wrote:
> Couple of input drivers depend on this symbol:
> 
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/tca8418_keypad.ko] undefined!
> ERROR: "matrix_keypad_parse_of_params" [drivers/input/keyboard/cros_ec_keyb.ko] undefined!
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Michal Marek <mmarek@suse.cz>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

This is coming through some other tree though so you 'll have to track
it down.

Thanks.

> ---
>  drivers/input/matrix-keymap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/matrix-keymap.c b/drivers/input/matrix-keymap.c
> index 619b382..08b61f5 100644
> --- a/drivers/input/matrix-keymap.c
> +++ b/drivers/input/matrix-keymap.c
> @@ -68,6 +68,7 @@ int matrix_keypad_parse_of_params(struct device *dev,
>  
>  	return 0;
>  }
> +EXPORT_SYMBOL_GPL(matrix_keypad_parse_of_params);
>  
>  static int matrix_keypad_parse_of_keymap(const char *propname,
>  					 unsigned int rows, unsigned int cols,
> -- 
> 1.8.2.1
> 

-- 
Dmitry

  reply	other threads:[~2013-04-15 16:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 12:06 [PATCH] input: Export matrix_keypad_parse_of_params() Michal Marek
2013-04-15 16:07 ` Dmitry Torokhov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-04-16  8:50 Michal Marek
2013-04-17 17:54 ` Randy Dunlap
2013-04-17 18:11 ` Simon Glass
2013-04-18 22:31 ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130415160747.GA19223@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rdunlap@infradead.org \
    --cc=sjg@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox