public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86:aperture_64: drop not needed checking
@ 2013-04-16  1:37 Wang YanQing
  2013-04-16 13:50 ` [tip:x86/mm] x86/mm/gart: Drop unnecessary check tip-bot for Wang YanQing
  0 siblings, 1 reply; 2+ messages in thread
From: Wang YanQing @ 2013-04-16  1:37 UTC (permalink / raw)
  To: mingo; +Cc: yinghai, linux-kernel


The memblock_find_in_range return value, addr, will
make sure "addr + aper_size" not beyond GART_MAX_ADDR.

Signed-off-by: Wang YanQing <udknight@gmail.com>
---
 arch/x86/kernel/aperture_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
index d5fd66f..fd972a3 100644
--- a/arch/x86/kernel/aperture_64.c
+++ b/arch/x86/kernel/aperture_64.c
@@ -87,7 +87,7 @@ static u32 __init allocate_aperture(void)
 	 */
 	addr = memblock_find_in_range(GART_MIN_ADDR, GART_MAX_ADDR,
 				      aper_size, aper_size);
-	if (!addr || addr + aper_size > GART_MAX_ADDR) {
+	if (!addr) {
 		printk(KERN_ERR
 			"Cannot allocate aperture memory hole (%lx,%uK)\n",
 				addr, aper_size>>10);
-- 
1.7.12.4.dirty

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:x86/mm] x86/mm/gart: Drop unnecessary check
  2013-04-16  1:37 [PATCH] x86:aperture_64: drop not needed checking Wang YanQing
@ 2013-04-16 13:50 ` tip-bot for Wang YanQing
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Wang YanQing @ 2013-04-16 13:50 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, tglx, udknight

Commit-ID:  26bfc540f6f2dcbd93d0b9ed8f37830419ded7e8
Gitweb:     http://git.kernel.org/tip/26bfc540f6f2dcbd93d0b9ed8f37830419ded7e8
Author:     Wang YanQing <udknight@gmail.com>
AuthorDate: Tue, 16 Apr 2013 09:37:34 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 16 Apr 2013 10:54:40 +0200

x86/mm/gart: Drop unnecessary check

The memblock_find_in_range() return value addr is guaranteed
to be within "addr + aper_size" and not beyond GART_MAX_ADDR.

Signed-off-by: Wang YanQing <udknight@gmail.com>
Cc: yinghai@kernel.org
Link: http://lkml.kernel.org/r/20130416013734.GA14641@udknight
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/aperture_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
index d5fd66f..fd972a3 100644
--- a/arch/x86/kernel/aperture_64.c
+++ b/arch/x86/kernel/aperture_64.c
@@ -87,7 +87,7 @@ static u32 __init allocate_aperture(void)
 	 */
 	addr = memblock_find_in_range(GART_MIN_ADDR, GART_MAX_ADDR,
 				      aper_size, aper_size);
-	if (!addr || addr + aper_size > GART_MAX_ADDR) {
+	if (!addr) {
 		printk(KERN_ERR
 			"Cannot allocate aperture memory hole (%lx,%uK)\n",
 				addr, aper_size>>10);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-04-16 13:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-16  1:37 [PATCH] x86:aperture_64: drop not needed checking Wang YanQing
2013-04-16 13:50 ` [tip:x86/mm] x86/mm/gart: Drop unnecessary check tip-bot for Wang YanQing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox