public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Robin Holt <holt@sgi.com>, Ingo Molnar <mingo@kernel.org>,
	"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
	Russ Anderson <rja@sgi.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH -v5 5/5] Make reboot_cpuid a kernel parameter.
Date: Wed, 17 Apr 2013 14:48:36 -0500	[thread overview]
Message-ID: <20130417194836.GK3658@sgi.com> (raw)
In-Reply-To: <516EF9DE.6000707@zytor.com>

On Wed, Apr 17, 2013 at 12:37:02PM -0700, H. Peter Anvin wrote:
> On 04/17/2013 11:43 AM, Robin Holt wrote:
> > Moving the reboot=s<##> parameter for x86 to a kernel parameter
> > proper.  I did not find any other arch that was specifying the
> > reboot cpu.
> > 
> > I left a compatibility mode in there.  The new parameter always
> > takes precedence.  I also fixed up the current code to support
> > up to cpuid's up to the current max of 4096.
> > 
> 
> I still don't understand why you insist on introducing a new parameter
> rather than just supporting the existing, somewhat ugly, syntax: it is
> rare enough to need that the compatibility wins over the aestetics.

Did you see my response I sent this morning?

I would really like to try and remove the apparently unused reboot=
parameter from arm and unicore32 as well.  Does anybody have a concern
with that?  That should make documenting slightly easier.

> Furthermore that word "cpuid" that you keep using, I don't think it
> means what you think it means...

If we stayed with the core_param, would you prefer reboot_processor=###
over reboot_cpuid=###?

Robin

  reply	other threads:[~2013-04-17 19:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17 18:43 [PATCH -v5 0/5] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-04-17 18:43 ` [PATCH -v5 1/5] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Robin Holt
2013-04-17 18:43 ` [PATCH -v5 2/5] Migrate shutdown/reboot to boot cpu Robin Holt
2013-04-17 18:43 ` [PATCH -v5 3/5] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-04-17 18:43 ` [PATCH -v5 4/5] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-04-17 19:13   ` Robin Holt
2013-04-17 18:43 ` [PATCH -v5 5/5] Make reboot_cpuid a kernel parameter Robin Holt
2013-04-17 19:37   ` H. Peter Anvin
2013-04-17 19:48     ` Robin Holt [this message]
2013-04-17 19:55       ` H. Peter Anvin
2013-04-17 19:59       ` H. Peter Anvin
2013-04-17 20:15         ` Robin Holt
2013-04-18  0:17           ` Robin Holt
2013-04-18  0:28             ` H. Peter Anvin
2013-04-18  0:39             ` H. Peter Anvin
2013-04-18  1:25               ` Robin Holt
2013-04-18  2:04                 ` Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130417194836.GK3658@sgi.com \
    --to=holt@sgi.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rja@sgi.com \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox