From: Josh Triplett <josh@joshtriplett.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: "Bryan O'Donoghue" <bryan.odonoghue.lkml@nexus-software.ie>,
matthew.garrett@nebula.com, linux-efi@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
Darren Hart <darren.hart@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Josh Boyer <jwboyer@redhat.com>
Subject: Re: [PATCH] Remove warning in efi_enter_virtual_mode
Date: Thu, 18 Apr 2013 09:33:26 -0700 [thread overview]
Message-ID: <20130418163325.GA6884@leaf> (raw)
In-Reply-To: <516FD24A.3070502@console-pimps.org>
On Thu, Apr 18, 2013 at 12:00:26PM +0100, Matt Fleming wrote:
> > No, no - we *don't* have a BGRT object at all.
> >
> > We have a completely clean memory map - but the BGRT code is causing the
> > is_ram() failure.
>
> You assume that mapping of the Boot Services regions is done purely for
> the benefit of pulling out the bgrt image - it's not, see the above
> commit log - and I assumed that you had an ACPI bgrt pointer in your
> memory map, but you don't.
>
> Darren, Josh, have you ever seen an i386 machine with a bgrt pointer? If
> not, and given that we've never seen an i386 firmware that requires the
> above workaround from Matthew, combined with the fact that there are so
> few i386 implementations out there, I'm inclined to apply the patch
> below, because anything else is a lot more work. We can address this
> properly if we ever start seeing i386 machines with bgrt pointers that
> reference highmem.
The machine I developed the BGRT changes on kept the image below the 4G
mark, inside one of the memory regions reclaimable via
ExitBootServices().
- Josh Triplett
next prev parent reply other threads:[~2013-04-18 16:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 15:58 [PATCH] Remove warning in efi_enter_virtual_mode Bryan O'Donoghue
2013-04-17 14:06 ` Matt Fleming
2013-04-17 22:00 ` Bryan O'Donoghue
2013-04-18 11:00 ` Matt Fleming
2013-04-18 13:40 ` Josh Boyer
2013-04-18 15:01 ` Matthew Garrett
2013-04-18 15:17 ` Josh Boyer
2013-04-18 14:51 ` Darren Hart
2013-04-18 16:19 ` Matt Fleming
2013-04-19 0:18 ` Darren Hart
2013-04-19 7:50 ` Matt Fleming
2013-04-19 12:01 ` Josh Boyer
2013-09-10 17:43 ` Darren Hart
2013-09-12 7:55 ` Matt Fleming
2013-09-12 22:30 ` Darren Hart
2013-04-18 16:33 ` Josh Triplett [this message]
2013-04-18 16:38 ` H. Peter Anvin
2013-04-18 16:44 ` Josh Triplett
2013-04-18 19:55 ` Matt Fleming
2013-04-18 19:57 ` H. Peter Anvin
2013-04-18 19:58 ` Matthew Garrett
2013-04-18 20:11 ` Darren Hart
2013-04-18 20:13 ` H. Peter Anvin
2013-04-18 20:17 ` Darren Hart
2013-04-18 20:45 ` H. Peter Anvin
2013-04-18 22:07 ` Bryan O'Donoghue
2013-04-18 23:01 ` Josh Triplett
2013-04-18 23:44 ` H. Peter Anvin
2013-04-18 23:42 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130418163325.GA6884@leaf \
--to=josh@joshtriplett.org \
--cc=bryan.odonoghue.lkml@nexus-software.ie \
--cc=darren.hart@intel.com \
--cc=hpa@zytor.com \
--cc=jwboyer@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=matthew.garrett@nebula.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).