[PATCH RFT] regulator: palmas: Fix min_uV for LDO8 tracking mode

[PATCH RFT] regulator: palmas: Fix min_uV for LDO8 tracking mode

[Axel Lin]

When SMPS45 is set to off and LDO8 tracking is enabled, the output voltage can
be set from 0.45 to 1.65 V. Thus set min_uV to be 450000.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Laxman,
My understanding is based on your comment in the code.
        /*
         * When SMPS45 is set to off and LDO8 tracking is enabled, the LDO8
         * output is defined by the LDO8_VOLTAGE.VSEL register divided by two,
         * and can be set from 0.45 to 1.65 V.
         */

Can you confirm if this patch is correct or not?
Axel

 drivers/regulator/palmas-regulator.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index d6efaf1..452d987 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -886,6 +886,7 @@ static int palmas_regulators_probe(struct platform_device *pdev)
 			if (pdata && (id == PALMAS_REG_LDO8) &&
 					pdata->enable_ldo8_tracking) {
 				palmas_enable_ldo8_track(palmas);
+				pmic->desc[id].min_uV = 450000;
 				pmic->desc[id].uV_step = 25000;
 			}
 		} else {
-- 
1.7.10.4

Re: [PATCH RFT] regulator: palmas: Fix min_uV for LDO8 tracking mode

[Laxman Dewangan]

On Thursday 18 April 2013 10:23 PM, Axel Lin wrote:
> When SMPS45 is set to off and LDO8 tracking is enabled, the output voltage can
> be set from 0.45 to 1.65 V. Thus set min_uV to be 450000.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Laxman,
> My understanding is based on your comment in the code.
>          /*
>           * When SMPS45 is set to off and LDO8 tracking is enabled, the LDO8
>           * output is defined by the LDO8_VOLTAGE.VSEL register divided by two,
>           * and can be set from 0.45 to 1.65 V.
>           */
>
> Can you confirm if this patch is correct or not?

Yes, this is correct.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>


Unfortunately the PMIC device which we have is having bug for which we 
are disabling tracking before going to suspend and enabling again in 
resume and hence it is not
caught. I will pull this change to my downstream also.

Re: [PATCH RFT] regulator: palmas: Fix min_uV for LDO8 tracking mode

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

On Fri, Apr 19, 2013 at 12:53:52AM +0800, Axel Lin wrote:
> When SMPS45 is set to off and LDO8 tracking is enabled, the output voltage can
> be set from 0.45 to 1.65 V. Thus set min_uV to be 450000.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]