From: Wang YanQing <udknight@gmail.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Renninger <trenn@suse.de>
Subject: Re: [PATCH]drivers:acpi: Fix wrong parameter passed to memblock_reserve
Date: Fri, 19 Apr 2013 12:40:46 +0800 [thread overview]
Message-ID: <20130419044046.GA9028@udknight> (raw)
In-Reply-To: <CAE9FiQUtvgB6zO9uqDQeC8K1kdH5uCwXkagAYUEEoF+Z+QHTdw@mail.gmail.com>
On Mon, Apr 15, 2013 at 07:47:38PM -0700, Yinghai Lu wrote:
> On Mon, Apr 15, 2013 at 6:44 PM, Wang YanQing <udknight@gmail.com> wrote:
> >
> > The parameter of memblock_reserve is start address,
> > and size, not address range.
> >
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
> > ---
> > drivers/acpi/osl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> > index 586e7e9..bcb7a3b 100644
> > --- a/drivers/acpi/osl.c
> > +++ b/drivers/acpi/osl.c
> > @@ -641,7 +641,7 @@ void __init acpi_initrd_override(void *data, size_t size)
> > * Both memblock_reserve and e820_add_region (via arch_reserve_mem_area)
> > * works fine.
> > */
> > - memblock_reserve(acpi_tables_addr, acpi_tables_addr + all_tables_size);
> > + memblock_reserve(acpi_tables_addr, all_tables_size);
> > arch_reserve_mem_area(acpi_tables_addr, all_tables_size);
>
> Acked-by: Yinghai Lu <yinghai@kernel.org>
>
> And it should go to stable for v3.8
Hi all, I think this fix should be merged before 3.9 is out,
it make no much sense to backport it for 3.9 later, but we don't have
much time before 3.9 is out, so...
Thanks.
next prev parent reply other threads:[~2013-04-19 4:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 1:44 [PATCH]drivers:acpi: Fix wrong parameter passed to memblock_reserve Wang YanQing
2013-04-16 2:47 ` Yinghai Lu
2013-04-19 4:40 ` Wang YanQing [this message]
2013-04-22 23:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419044046.GA9028@udknight \
--to=udknight@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=trenn@suse.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox