From: Chris Mason <clmason@fusionio.com>
To: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>
Cc: Wanlong Gao <gaowanlong@cn.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>,
"namhyung@gmail.com" <namhyung@gmail.com>,
"agk@redhat.com" <agk@redhat.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"neilb@suse.de" <neilb@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [BUG REPORT] Kernel panic on 3.9.0-rc7-4-gbb33db7
Date: Fri, 19 Apr 2013 09:52:14 -0400 [thread overview]
Message-ID: <20130419135214.30947.96188@localhost.localdomain> (raw)
In-Reply-To: <20130419133250.GR4816@kernel.dk>
Quoting Jens Axboe (2013-04-19 09:32:50)
> >
> > No wonder this thing crashes. Chris, can't the original bio carry
> > bbio in bi_private and let end_bio_extent_readpage() free the bbio
> > instead of abusing bi_bdev like this?
>
> Ugh, wtf.
>
> Chris, time for a swim in the bay :-)
Yeah, I can't really defend this one. We needed a space for an int and
I assumed end_io meant the FS was free to do horrible things.
Really though, I'll just take a quick dip in the lake and patch this out
of btrfs.
Jan is probably right about changing around our endio callbacks to
explicitly pass the mirror, it should be less complex and cleaner.
Many thanks to everyone here that tracked it down.
-chris
prev parent reply other threads:[~2013-04-19 13:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 8:36 [BUG REPORT] Kernel panic on 3.9.0-rc7-4-gbb33db7 Wanlong Gao
2013-04-17 14:46 ` Steven Rostedt
2013-04-18 12:37 ` Jens Axboe
2013-04-18 12:54 ` Wanlong Gao
2013-04-18 13:35 ` Jens Axboe
2013-04-18 14:14 ` Wanlong Gao
2013-04-18 14:30 ` Jens Axboe
2013-04-18 14:45 ` Wanlong Gao
2013-04-18 17:52 ` Tejun Heo
2013-04-19 4:06 ` Wanlong Gao
2013-04-18 16:08 ` Linus Torvalds
2013-04-18 17:27 ` Tejun Heo
2013-04-18 17:39 ` Jens Axboe
2013-04-18 18:07 ` Tejun Heo
2013-04-18 18:13 ` Jens Axboe
2013-04-18 19:10 ` Linus Torvalds
2013-04-18 20:37 ` Jens Axboe
2013-04-19 1:08 ` srostedt@gmail.com
2013-04-19 6:10 ` Wanlong Gao
2013-04-19 3:33 ` Wanlong Gao
2013-04-19 5:57 ` Tejun Heo
2013-04-19 6:17 ` Tejun Heo
2013-04-19 6:30 ` Wanlong Gao
2013-04-19 13:31 ` Jens Axboe
2013-04-19 8:24 ` Jan Schmidt
2013-04-19 12:15 ` Chris Mason
2013-04-19 13:32 ` Jens Axboe
2013-04-19 13:52 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419135214.30947.96188@localhost.localdomain \
--to=clmason@fusionio.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=neilb@suse.de \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox