public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] perf, x86: Fix some broken initconsts
Date: Sun, 21 Apr 2013 11:56:26 +0200	[thread overview]
Message-ID: <20130421095626.GA10683@gmail.com> (raw)
In-Reply-To: <1366515819-18081-1-git-send-email-andi@firstfloor.org>


* Andi Kleen <andi@firstfloor.org> wrote:

> From: Andi Kleen <ak@linux.intel.com>
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> diff --git a/arch/x86/kernel/cpu/perf_event_knc.c b/arch/x86/kernel/cpu/perf_event_knc.c
> index 4b7731b..2cfe648 100644
> --- a/arch/x86/kernel/cpu/perf_event_knc.c
> +++ b/arch/x86/kernel/cpu/perf_event_knc.c
> @@ -17,7 +17,7 @@ static const u64 knc_perfmon_event_map[] =
>    [PERF_COUNT_HW_BRANCH_MISSES]		= 0x002b,
>  };
>  
> -static __initconst u64 knc_hw_cache_event_ids
> +static __initconst const u64 knc_hw_cache_event_ids
>  				[PERF_COUNT_HW_CACHE_MAX]
>  				[PERF_COUNT_HW_CACHE_OP_MAX]
>  				[PERF_COUNT_HW_CACHE_RESULT_MAX] =
> @@ -284,7 +284,7 @@ static struct attribute *intel_knc_formats_attr[] = {
>  	NULL,
>  };
>  
> -static __initconst struct x86_pmu knc_pmu = {
> +static __initconst const struct x86_pmu knc_pmu = {
>  	.name			= "knc",
>  	.handle_irq		= knc_pmu_handle_irq,
>  	.disable_all		= knc_pmu_disable_all,

Already fixed in:

  c391c7884633 x86: Constify a few items

Thanks,

	Ingo

      reply	other threads:[~2013-04-21  9:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-21  3:43 [PATCH] perf, x86: Fix some broken initconsts Andi Kleen
2013-04-21  9:56 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130421095626.GA10683@gmail.com \
    --to=mingo@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jbeulich@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox